Skip to content

Commit

Permalink
AX: Fix accessibility/mac/mathml-elements.html test
Browse files Browse the repository at this point in the history
https://bugs.webkit.org/show_bug.cgi?id=148393

Patch by Nan Wang <n_wang@apple.com> on 2015-08-24
Reviewed by Chris Fleizach.

Updated the test to match the structure changes of mfenced/mo operators in bug 124838.

* accessibility/mac/mathml-elements-expected.txt:
* accessibility/mac/mathml-elements.html:
* platform/mac/TestExpectations:

Canonical link: https://commits.webkit.org/166520@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@188893 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
Nan Wang authored and webkit-commit-queue committed Aug 24, 2015
1 parent ec67946 commit 36ffdd0
Show file tree
Hide file tree
Showing 4 changed files with 21 additions and 8 deletions.
13 changes: 13 additions & 0 deletions LayoutTests/ChangeLog
@@ -1,3 +1,16 @@
2015-08-24 Nan Wang <n_wang@apple.com>

AX: Fix accessibility/mac/mathml-elements.html test
https://bugs.webkit.org/show_bug.cgi?id=148393

Reviewed by Chris Fleizach.

Updated the test to match the structure changes of mfenced/mo operators in bug 124838.

* accessibility/mac/mathml-elements-expected.txt:
* accessibility/mac/mathml-elements.html:
* platform/mac/TestExpectations:

2015-08-24 Chris Dumez <cdumez@apple.com>

NodeList should not have a named getter
Expand Down
8 changes: 4 additions & 4 deletions LayoutTests/accessibility/mac/mathml-elements-expected.txt
Expand Up @@ -67,13 +67,13 @@ PASS fenced.role is 'AXRole: AXGroup'
PASS fenced.subrole is 'AXSubrole: AXMathFenced'
PASS fenced.stringAttributeValue('AXMathFencedOpen') is '{'
PASS fenced.stringAttributeValue('AXMathFencedClose') is '}'
PASS child.childAtIndex(0).stringValue is 'AXValue: {'
PASS child.stringValue is 'AXValue: {'
PASS child.childAtIndex(0).stringValue is 'AXValue: 2'
PASS child.childAtIndex(0).stringValue is 'AXValue: ,'
PASS child.stringValue is 'AXValue: ,'
PASS child.childAtIndex(0).stringValue is 'AXValue: a'
PASS child.childAtIndex(0).stringValue is 'AXValue: ,'
PASS child.stringValue is 'AXValue: ,'
PASS child.childAtIndex(0).stringValue is 'AXValue: e'
PASS child.childAtIndex(0).stringValue is 'AXValue: }'
PASS child.stringValue is 'AXValue: }'
PASS sub.role is 'AXRole: AXGroup'
PASS sub.subrole is 'AXSubrole: AXMathSubscriptSuperscript'
PASS subBase.subrole is 'AXSubrole: AXMathIdentifier'
Expand Down
5 changes: 4 additions & 1 deletion LayoutTests/accessibility/mac/mathml-elements.html
Expand Up @@ -111,7 +111,10 @@
var fenceValues = new Array("{", "2", ",", "a", ",", "e", "}");
for (var k = 0; k < fenceValues.length; k++) {
var child = fenced.childAtIndex(k);
shouldBe("child.childAtIndex(0).stringValue", "'AXValue: " + fenceValues[k] + "'");
if (!child.childAtIndex(0))
shouldBe("child.stringValue", "'AXValue: " + fenceValues[k] + "'");
else
shouldBe("child.childAtIndex(0).stringValue", "'AXValue: " + fenceValues[k] + "'");
}

// Subscript
Expand Down
3 changes: 0 additions & 3 deletions LayoutTests/platform/mac/TestExpectations
Expand Up @@ -806,9 +806,6 @@ webkit.org/b/129180 svg/clip-path/clip-path-on-svg-002.svg [ ImageOnlyFailure ]
# Skipped for ios-simulator as well:
webkit.org/b/129758 js/dom/create-lots-of-workers.html [ Skip ]

# This test fails because the structure of mfenced/mo operators was changed in bug 124838.
webkit.org/b/124836 accessibility/mac/mathml-elements.html [ Failure ]

webkit.org/b/130693 mathml/presentation/tokenElements-background-color.html [ ImageOnlyFailure ]

# These tests require an OpenType MATH font on the Apple bots.
Expand Down

0 comments on commit 36ffdd0

Please sign in to comment.