[WGSL] Error opening https://threejs.org/examples/?q=webgpu#webgpu_co…

…mpute_texture_pingpong

https://bugs.webkit.org/show_bug.cgi?id=264272
rdar://118009042

Reviewed by Mike Wyrzykowski.

During code generation we were cleaning out the flag that we needed to generate
the division helper, but that is incorrect, since the flag is only set during
type checking, so it won't be set for subsequent compilations. The reason the other
similar flags around it need to be cleaned is that they are set during compilation
instead of checking. This whole system needs to be rafactored soon, but in the
mean time this fixes the sample.

* Source/WebGPU/WGSL/Metal/MetalFunctionWriter.cpp:
(WGSL::Metal::FunctionDefinitionWriter::emitNecessaryHelpers):
* Source/WebGPU/WGSL/WGSLShaderModule.h:
(WGSL::ShaderModule::setUsesWorkgroupUniformLoad):
(WGSL::ShaderModule::setUsesDivision):
(WGSL::ShaderModule::clearUsesWorkgroupUniformLoad): Deleted.
(WGSL::ShaderModule::clearUsesDivision): Deleted.

Canonical link: https://commits.webkit.org/270328@main

Source/WebGPU/WGSL/Metal/MetalFunctionWriter.cpp

@@ -215,7 +215,6 @@ void FunctionDefinitionWriter::emitNecessaryHelpers()
     }
 
     if (m_callGraph.ast().usesWorkgroupUniformLoad()) {
-        m_callGraph.ast().clearUsesWorkgroupUniformLoad();
         m_stringBuilder.append(m_indent, "template<typename T>\n");
         m_stringBuilder.append(m_indent, "T __workgroup_uniform_load(threadgroup T* const ptr)\n");
         m_stringBuilder.append(m_indent, "{\n");
@@ -230,7 +229,6 @@ void FunctionDefinitionWriter::emitNecessaryHelpers()
     }
 
     if (m_callGraph.ast().usesDivision()) {
-        m_callGraph.ast().clearUsesDivision();
         m_stringBuilder.append(m_indent, "template<typename T, typename U, typename V = conditional_t<is_scalar_v<U>, T, U>>\n");
         m_stringBuilder.append(m_indent, "V __wgslDiv(T lhs, U rhs)\n");
         m_stringBuilder.append(m_indent, "{\n");

Source/WebGPU/WGSL/WGSLShaderModule.h

@@ -78,11 +78,9 @@ class ShaderModule {
 
     bool usesWorkgroupUniformLoad() const { return m_usesWorkgroupUniformLoad; }
     void setUsesWorkgroupUniformLoad() { m_usesWorkgroupUniformLoad = true; }
-    void clearUsesWorkgroupUniformLoad() { m_usesWorkgroupUniformLoad = false; }
 
     bool usesDivision() const { return m_usesDivision; }
     void setUsesDivision() { m_usesDivision = true; }
-    void clearUsesDivision() { m_usesDivision = false; }
 
     template<typename T>
     std::enable_if_t<std::is_base_of_v<AST::Node, T>, void> replace(T* current, T&& replacement)