Skip to content

Commit

Permalink
REGRESSION (r278121): Fix build failure due to weak external symbol
Browse files Browse the repository at this point in the history
Occurs when building coverage+release builds:

    ERROR: symbol _DDHighlightCreateWithRectsInVisibleRectWithStyleScaleAndDirection

The soft-linked symbol was originally added in r259276.

* Configurations/WebCore.unexp:
- Add _DDHighlightCreateWithRectsInVisibleRectWithStyleScaleAndDirection
  to the list of unexported symbols.
- Also sort symbols in the group alphabetically.

Canonical link: https://commits.webkit.org/238481@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@278461 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
David Kilzer committed Jun 4, 2021
1 parent 9fb7dfe commit 3a671c1
Show file tree
Hide file tree
Showing 2 changed files with 18 additions and 2 deletions.
15 changes: 15 additions & 0 deletions Source/WebCore/ChangeLog
Original file line number Diff line number Diff line change
@@ -1,3 +1,18 @@
2021-06-04 David Kilzer <ddkilzer@apple.com>

REGRESSION (r278121): Fix build failure due to weak external symbol

Occurs when building coverage+release builds:

ERROR: symbol _DDHighlightCreateWithRectsInVisibleRectWithStyleScaleAndDirection

The soft-linked symbol was originally added in r259276.

* Configurations/WebCore.unexp:
- Add _DDHighlightCreateWithRectsInVisibleRectWithStyleScaleAndDirection
to the list of unexported symbols.
- Also sort symbols in the group alphabetically.

2021-06-04 Michael Catanzaro <mcatanzaro@gnome.org>

Fix more GCC warnings
Expand Down
5 changes: 3 additions & 2 deletions Source/WebCore/Configurations/WebCore.unexp
Original file line number Diff line number Diff line change
Expand Up @@ -47,9 +47,10 @@ _VTPixelTransferSessionTransferImage
_DDDFAScannerCreateFromCache
_DDDFAScannerFirstResultInUnicharArray
# Source/WebCore/page/mac/ServicesOverlayController.mm
_DDHighlightGetLayerWithContext
_DDHighlightGetBoundingRect
_DDHighlightCreateWithRectsInVisibleRectWithStyleAndDirection
_DDHighlightCreateWithRectsInVisibleRectWithStyleScaleAndDirection
_DDHighlightGetBoundingRect
_DDHighlightGetLayerWithContext
_DDHighlightPointIsOnHighlight


Expand Down

0 comments on commit 3a671c1

Please sign in to comment.