Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge r228109 - Storage Access API: Add testRunner.getAllStorageAcces…
…sEntries() to make testing easier and more explicit https://bugs.webkit.org/show_bug.cgi?id=181601 <rdar://problem/36475837> Reviewed by Alex Christensen. Source/WebCore: No new tests. Existing test updated. http/tests/storageAccess/request-and-grant-access-then-detach-should-not-have-access.html was found to be flaky. With the testRunner.hasStorageAccessEntry() getter it's possible to check access even if a frame doesn't respond timely to postMessage after detach and attach. * platform/network/NetworkStorageSession.h: * platform/network/cf/NetworkStorageSessionCFNet.cpp: (WebCore::NetworkStorageSession::getAllStorageAccessEntries const): Source/WebKit: http/tests/storageAccess/request-and-grant-access-then-detach-should-not-have-access.html was found to be flaky. With the testRunner.hasStorageAccessEntry() getter it's possible to check access even if a frame doesn't respond timely to postMessage after detach and attach. * NetworkProcess/NetworkProcess.cpp: (WebKit::NetworkProcess::getAllStorageAccessEntries): * NetworkProcess/NetworkProcess.h: * NetworkProcess/NetworkProcess.messages.in: * UIProcess/API/Cocoa/WKWebsiteDataStore.mm: (-[WKWebsiteDataStore _getAllStorageAccessEntries:]): * UIProcess/API/Cocoa/WKWebsiteDataStorePrivate.h: * UIProcess/Network/NetworkProcessProxy.cpp: (WebKit::NetworkProcessProxy::getAllStorageAccessEntries): (WebKit::NetworkProcessProxy::allStorageAccessEntriesResult): * UIProcess/Network/NetworkProcessProxy.h: * UIProcess/Network/NetworkProcessProxy.messages.in: * UIProcess/WebsiteData/WebsiteDataStore.cpp: (WebKit::WebsiteDataStore::getAllStorageAccessEntries): * UIProcess/WebsiteData/WebsiteDataStore.h: Tools: http/tests/storageAccess/request-and-grant-access-then-detach-should-not-have-access.html was found to be flaky. With the testRunner.hasStorageAccessEntry() getter it's possible to check access even if a frame doesn't respond timely to postMessage after detach and attach. * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl: * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: (WTR::InjectedBundle::didReceiveMessageToPage): * WebKitTestRunner/InjectedBundle/TestRunner.cpp: (WTR::TestRunner::setStorageAccessAPIEnabled): Just moved for source file grouping. (WTR::TestRunner::getAllStorageAccessEntries): (WTR::TestRunner::callDidReceiveAllStorageAccessEntriesCallback): * WebKitTestRunner/InjectedBundle/TestRunner.h: * WebKitTestRunner/TestController.cpp: (WTR::TestController::getAllStorageAccessEntries): Note that this is just stubbed out, i.e. not implemented. * WebKitTestRunner/TestController.h: * WebKitTestRunner/TestInvocation.cpp: (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle): (WTR::TestInvocation::didReceiveAllStorageAccessEntries): * WebKitTestRunner/TestInvocation.h: * WebKitTestRunner/cocoa/TestControllerCocoa.mm: (WTR::TestController::getAllStorageAccessEntries): This is the Cocoa-specific version of this test infrastructure. LayoutTests: http/tests/storageAccess/request-and-grant-access-then-detach-should-not-have-access.html was found to be flaky. With the testRunner.hasStorageAccessEntry() getter it's possible to check access even if a frame doesn't respond timely to postMessage after detach and attach. * http/tests/storageAccess/request-and-grant-access-then-detach-should-not-have-access-expected.txt: * http/tests/storageAccess/request-and-grant-access-then-detach-should-not-have-access.html: * platform/mac-wk2/TestExpectations: http/tests/storageAccess/request-and-grant-access-then-navigate-should-not-have-access.html no longer marked as flaky. Note that the wrong test was marked flaky. It should have been http/tests/storageAccess/request-and-grant-access-then-detach-should-not-have-access.html.
- Loading branch information
1 parent
49c224a
commit 3d2a827
Showing
28 changed files
with
310 additions
and
39 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.