Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[CSS Container Queries] Correct container selection for pseudo-elements
https://bugs.webkit.org/show_bug.cgi?id=239279 Reviewed by Simon Fraser. Source/WebCore: The element itself may be the container for its pseudo-elements. * css/CSSPrimitiveValue.cpp: (WebCore::CSSPrimitiveValue::computeNonCalcLengthDouble): * style/ContainerQueryEvaluator.cpp: (WebCore::Style::ContainerQueryEvaluator::ContainerQueryEvaluator): (WebCore::Style::ContainerQueryEvaluator::selectContainer const): (WebCore::Style::ContainerQueryEvaluator::selectContainer): * style/ContainerQueryEvaluator.h: Instead of passing the pseudo-element being matched, pass a container selection mode flag. The exact pseudo-element type doesn't matter. * style/ElementRuleCollector.cpp: (WebCore::Style::ElementRuleCollector::containerQueriesMatch): We need to use the pseudo-element mode when matching a rule that matches a pseudo-element, even when we are not actually resolving the pseudo element. This is because regular element rule matching sets the style bits that indicate what pseudo-elements the element has. LayoutTests: * TestExpectations: Canonical link: https://commits.webkit.org/249599@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@292819 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- Loading branch information
Showing
7 changed files
with
55 additions
and
16 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters