Merge r235198 - Eliminate dead code operationThrowDivideError() and o…

…perationThrowOutOfBoundsAccessError() https://bugs.webkit.org/show_bug.cgi?id=188859 Rubber-stamped by Saam Barati. Deleted these two functions. * jit/JITOperations.cpp: * jit/JITOperations.h:
WebKit · Nov 16, 2018 · 3f255b7 · 3f255b7
1 parent 3ce4ab8
commit 3f255b7
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 32 deletions.
diff --git a/Source/JavaScriptCore/ChangeLog b/Source/JavaScriptCore/ChangeLog
@@ -1,3 +1,15 @@
+2018-08-22  Michael Saboff  <msaboff@apple.com>
+
+        https://bugs.webkit.org/show_bug.cgi?id=188859
+        Eliminate dead code operationThrowDivideError() and operationThrowOutOfBoundsAccessError()
+
+        Rubber-stamped by Saam Barati.
+
+        Deleted these two functions.
+
+        * jit/JITOperations.cpp:
+        * jit/JITOperations.h:
+
 2018-11-04  Adrian Perez de Castro  <aperez@igalia.com>
 
         [GTK] Cannot make debug builds of JSC using release 2.22.3

diff --git a/Source/JavaScriptCore/jit/JITOperations.cpp b/Source/JavaScriptCore/jit/JITOperations.cpp
@@ -114,34 +114,6 @@ void JIT_OPERATION operationThrowStackOverflowError(ExecState* exec, CodeBlock*
     throwStackOverflowError(callerFrame, scope);
 }
 
-#if ENABLE(WEBASSEMBLY)
-void JIT_OPERATION operationThrowDivideError(ExecState* exec)
-{
-    VM* vm = &exec->vm();
-    auto scope = DECLARE_THROW_SCOPE(*vm);
-
-    EntryFrame* entryFrame = vm->topEntryFrame;
-    CallFrame* callerFrame = exec->callerFrame(entryFrame);
-
-    NativeCallFrameTracerWithRestore tracer(vm, entryFrame, callerFrame);
-    ErrorHandlingScope errorScope(*vm);
-    throwException(callerFrame, scope, createError(callerFrame, "Division by zero or division overflow."_s));
-}
-
-void JIT_OPERATION operationThrowOutOfBoundsAccessError(ExecState* exec)
-{
-    VM* vm = &exec->vm();
-    auto scope = DECLARE_THROW_SCOPE(*vm);
-
-    EntryFrame* entryFrame = vm->topEntryFrame;
-    CallFrame* callerFrame = exec->callerFrame(entryFrame);
-
-    NativeCallFrameTracerWithRestore tracer(vm, entryFrame, callerFrame);
-    ErrorHandlingScope errorScope(*vm);
-    throwException(callerFrame, scope, createError(callerFrame, "Out-of-bounds access."_s));
-}
-#endif
-
 int32_t JIT_OPERATION operationCallArityCheck(ExecState* exec)
 {
     VM* vm = &exec->vm();

diff --git a/Source/JavaScriptCore/jit/JITOperations.h b/Source/JavaScriptCore/jit/JITOperations.h
@@ -353,10 +353,6 @@ void JIT_OPERATION lookupExceptionHandlerFromCallerFrame(VM*, ExecState*) WTF_IN
 void JIT_OPERATION operationVMHandleException(ExecState*) WTF_INTERNAL;
 
 void JIT_OPERATION operationThrowStackOverflowError(ExecState*, CodeBlock*) WTF_INTERNAL;
-#if ENABLE(WEBASSEMBLY)
-void JIT_OPERATION operationThrowDivideError(ExecState*) WTF_INTERNAL;
-void JIT_OPERATION operationThrowOutOfBoundsAccessError(ExecState*) WTF_INTERNAL;
-#endif
 int32_t JIT_OPERATION operationCallArityCheck(ExecState*) WTF_INTERNAL;
 int32_t JIT_OPERATION operationConstructArityCheck(ExecState*) WTF_INTERNAL;
 EncodedJSValue JIT_OPERATION operationTryGetById(ExecState*, StructureStubInfo*, EncodedJSValue, UniquedStringImpl*) WTF_INTERNAL;