Skip to content

Commit

Permalink
Merge r181938 - [GTK][WK2] WebPageProxy::failedToShowPopupMenu() virt…
Browse files Browse the repository at this point in the history
…ual method should be marked as override

https://bugs.webkit.org/show_bug.cgi?id=143045

Reviewed by Carlos Garcia Campos.

* UIProcess/WebPageProxy.h: Mark the failedToShowPopupMenu(), inherited from
the WebPopupMenuProxy::Client class, as overridden.
  • Loading branch information
zdobersek authored and carlosgcampos committed Mar 25, 2015
1 parent 06a81ad commit 405e960
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 1 deletion.
10 changes: 10 additions & 0 deletions Source/WebKit2/ChangeLog
@@ -1,3 +1,13 @@
2015-03-25 Zan Dobersek <zdobersek@igalia.com>

[GTK][WK2] WebPageProxy::failedToShowPopupMenu() virtual method should be marked as override
https://bugs.webkit.org/show_bug.cgi?id=143045

Reviewed by Carlos Garcia Campos.

* UIProcess/WebPageProxy.h: Mark the failedToShowPopupMenu(), inherited from
the WebPopupMenuProxy::Client class, as overridden.

2015-03-25 Zan Dobersek <zdobersek@igalia.com>

[WK2] Clean up DrawingAreaImpl vtable overrides
Expand Down
2 changes: 1 addition & 1 deletion Source/WebKit2/UIProcess/WebPageProxy.h
Expand Up @@ -1025,7 +1025,7 @@ class WebPageProxy : public API::ObjectImpl<API::Object::Type::Page>
virtual void valueChangedForPopupMenu(WebPopupMenuProxy*, int32_t newSelectedIndex) override;
virtual void setTextFromItemForPopupMenu(WebPopupMenuProxy*, int32_t index) override;
#if PLATFORM(GTK)
virtual void failedToShowPopupMenu();
virtual void failedToShowPopupMenu() override;
#endif

void didCreateMainFrame(uint64_t frameID);
Expand Down

0 comments on commit 405e960

Please sign in to comment.