Reading logging preference file takes time on launch

https://bugs.webkit.org/show_bug.cgi?id=259483 rdar://112840318 Reviewed by Brent Fulgham. Reading the logging preference file is using 30-40ms of CPU time when launching the WebContent process on iOS. This patch proposes that we remove the file, and instead set the preferences manually when needed. * Source/WebKit/Configurations/WebKit.xcconfig: * Source/WebKit/Resources/Signposts/LoggingPreferences.plist: Removed. * Source/WebKit/WebKit.xcodeproj/project.pbxproj: Canonical link: https://commits.webkit.org/266362@main
WebKit · Jul 27, 2023 · 4232eab · 4232eab
1 parent f89b851
commit 4232eab
Show file tree

Hide file tree

Showing 3 changed files with 0 additions and 17 deletions.
diff --git a/Source/WebKit/Configurations/WebKit.xcconfig b/Source/WebKit/Configurations/WebKit.xcconfig
@@ -261,10 +261,6 @@ WK_HAVE_URL_FORMATTING_appletvsimulator = NO;
 WK_HAVE_URL_FORMATTING_macosx = $(WK_HAVE_URL_FORMATTING$(WK_MACOS_1014));
 WK_HAVE_URL_FORMATTING_MACOS_SINCE_1014 = YES;
 
-WK_LOGGING_PREFERENCES_OUTPUT_PATH = $(WK_LOGGING_PREFERENCES_OUTPUT_PATH_USE_OVERRIDE_FRAMEWORKS_DIR_$(WK_USE_OVERRIDE_FRAMEWORKS_DIR)_$(WK_PLATFORM_NAME));
-WK_LOGGING_PREFERENCES_OUTPUT_PATH_USE_OVERRIDE_FRAMEWORKS_DIR_NO_macosx = $(DSTROOT)/System/Library/Preferences/Logging/Subsystems/com.apple.WebKit.plist;
-WK_LOGGING_PREFERENCES_OUTPUT_PATH_USE_OVERRIDE_FRAMEWORKS_DIR_NO_iphoneos = $(DSTROOT)/System/Library/Preferences/Logging/Subsystems/com.apple.WebKit.plist;
-
 WK_TRACE_POINTS_OUTPUT_PATH = $(WK_TRACE_POINTS_OUTPUT_PATH_USE_OVERRIDE_FRAMEWORKS_DIR_$(WK_USE_OVERRIDE_FRAMEWORKS_DIR)_$(WK_PLATFORM_NAME));
 WK_TRACE_POINTS_OUTPUT_PATH_USE_OVERRIDE_FRAMEWORKS_DIR_NO_macosx = $(DSTROOT)/AppleInternal/Library/Ariadne/Plists/WebKit.plist;
 WK_TRACE_POINTS_OUTPUT_PATH_USE_OVERRIDE_FRAMEWORKS_DIR_NO_iphoneos = $(DSTROOT)/AppleInternal/Library/Ariadne/Plists/WebKit.plist;

diff --git a/Source/WebKit/Resources/Signposts/LoggingPreferences.plist b/Source/WebKit/Resources/Signposts/LoggingPreferences.plist
diff --git a/Source/WebKit/WebKit.xcodeproj/project.pbxproj b/Source/WebKit/WebKit.xcodeproj/project.pbxproj
@@ -16869,14 +16869,12 @@
 			inputFileListPaths = (
 			);
 			inputPaths = (
-				"$(SRCROOT)/Resources/Signposts/LoggingPreferences.plist",
 				"$(SRCROOT)/Resources/Signposts/SystemTracePoints.plist",
 			);
 			name = "Copy Signpost Plists";
 			outputFileListPaths = (
 			);
 			outputPaths = (
-				"$(WK_LOGGING_PREFERENCES_OUTPUT_PATH)",
 				"$(WK_TRACE_POINTS_OUTPUT_PATH)",
 			);
 			runOnlyForDeploymentPostprocessing = 1;