Skip to content

Commit

Permalink
REGRESSION(227811@main): run-webkit-tests reports "perl: warning: Set…
Browse files Browse the repository at this point in the history
…ting locale failed." on Windows

https://bugs.webkit.org/show_bug.cgi?id=259640

Reviewed by Don Olmstead.

After 227811@main set a environment vairable 'LC_ALL' to
'en_US.UTF-8', run-webkit-tests reports "perl: warning: Setting locale
failed." on Windows.

> perl: warning: Setting locale failed.
> perl: warning: Please check that your locale settings:
> 	LC_ALL = "en_US.UTF-8",
> 	LC_MESSAGES = "en_US.UTF-8",
> 	LANG = "en_US.UTF-8"
>     are supported and installed on your system.
> perl: warning: Falling back to the standard locale ("C").

* Tools/Scripts/webkitpy/common/host.py:
(Host._engage_awesome_locale_hacks):
Do nothing on Windows.

Canonical link: https://commits.webkit.org/266671@main
  • Loading branch information
fujii committed Aug 8, 2023
1 parent 7e92833 commit 42fcbb0
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions Tools/Scripts/webkitpy/common/host.py
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,8 @@ def web(self):
# We call this from the Host constructor, as it's one of the
# earliest calls made for all webkitpy-based programs.
def _engage_awesome_locale_hacks(self):
if sys.platform.startswith('win'):
return
# To make life easier on our non-english users, we override
# the locale environment variables inside webkitpy.
# If we don't do this, programs like SVN will output localized
Expand Down

0 comments on commit 42fcbb0

Please sign in to comment.