Skip to content

Commit

Permalink
[WebGPU] Queue may try to encode blit operations on detached encoder
Browse files Browse the repository at this point in the history
https://bugs.webkit.org/show_bug.cgi?id=274289
<radar://128202303>

Reviewed by Dan Glastonbury.

ensureBlitCommandEncoder needs to ensure the encoding hasn't
ended otherwise a new blit command encoder needs to be created.

Depends on #28680 for the test
to pass.

* LayoutTests/TestExpectations:
* LayoutTests/fast/webgpu/fuzz-274289-expected.txt: Added.
* LayoutTests/fast/webgpu/fuzz-274289.html: Added.
Add regression test.

* Source/WebGPU/WebGPU/Queue.mm:
(WebGPU::Queue::ensureBlitCommandEncoder):

Canonical link: https://commits.webkit.org/279026@main
  • Loading branch information
mwyrzykowski committed May 21, 2024
1 parent 5e19b9f commit 4349cc0
Show file tree
Hide file tree
Showing 4 changed files with 18,462 additions and 1 deletion.
2 changes: 2 additions & 0 deletions LayoutTests/TestExpectations
Original file line number Diff line number Diff line change
Expand Up @@ -2129,6 +2129,8 @@ webkit.org/b/139639 [ Debug ] cssom/non-subpixel-scroll-top-left-values.html [ S
[ Release ] fast/webgpu/fuzz-274317.html [ Pass Failure Timeout ]
[ Debug ] fast/webgpu/fuzz-274334.html [ Skip ]
[ Release ] fast/webgpu/fuzz-274334.html [ Pass Failure Timeout ]
[ Debug ] fast/webgpu/fuzz-274289.html [ Skip ]
[ Release ] fast/webgpu/fuzz-274289.html [ Pass Failure Timeout ]

# Imported W3C HTML/DOM ref tests that are failing.
imported/w3c/web-platform-tests/html/dom/elements/global-attributes/dir_auto-textarea-script-N-between-Rs.html [ ImageOnlyFailure ]
Expand Down

0 comments on commit 4349cc0

Please sign in to comment.