Scroll corner painting ignores color-scheme when overflow: scroll

https://bugs.webkit.org/show_bug.cgi?id=258482

Reviewed by Aditya Keerthi.

Update the local appearance value before painting Mac scroll corner.

This means that the color-scheme is correctly accounted for when painting the scroll corner for both frame views and scrollable areas.

* Source/WebCore/page/LocalFrameView.cpp:
(WebCore::LocalFrameView::paintScrollCorner):
* Source/WebCore/platform/mac/ScrollbarThemeMac.mm:
(WebCore::ScrollbarThemeMac::paintScrollCorner):

Canonical link: https://commits.webkit.org/265687@main

Source/WebCore/page/LocalFrameView.cpp

@@ -140,10 +140,6 @@
 #include "LegacyTileCache.h"
 #endif
 
-#if PLATFORM(MAC)
-#include "LocalDefaultSystemAppearance.h"
-#endif
-
 #include "DisplayView.h"
 #include "LayoutContext.h"
 
@@ -4570,11 +4566,6 @@ void LocalFrameView::paintScrollCorner(GraphicsContext& context, const IntRect&
         return;
     }
 
-#if PLATFORM(MAC)
-    // Keep this in sync with ScrollAnimatorMac's effectiveAppearanceForScrollerImp:.
-    LocalDefaultSystemAppearance localAppearance(useDarkAppearanceForScrollbars());
-#endif
-
     ScrollView::paintScrollCorner(context, cornerRect);
 }
 

Source/WebCore/platform/mac/ScrollbarThemeMac.mm

@@ -32,6 +32,7 @@
 #import "GraphicsLayer.h"
 #import "ImageBuffer.h"
 #import "LocalCurrentGraphicsContext.h"
+#import "LocalDefaultSystemAppearance.h"
 #import "NSScrollerImpDetails.h"
 #import "PlatformMouseEvent.h"
 #import "ScrollView.h"
@@ -582,11 +583,14 @@ static void paintScrollbar(Scrollbar& scrollbar, GraphicsContext& context)
     return true;
 }
 
-void ScrollbarThemeMac::paintScrollCorner(ScrollableArea&, GraphicsContext& context, const IntRect& cornerRect)
+void ScrollbarThemeMac::paintScrollCorner(ScrollableArea& area, GraphicsContext& context, const IntRect& cornerRect)
 {
     if (context.paintingDisabled())
         return;
 
+    // Keep this in sync with ScrollAnimatorMac's effectiveAppearanceForScrollerImp:.
+    LocalDefaultSystemAppearance localAppearance(area.useDarkAppearanceForScrollbars());
+
     context.drawSystemImage(ScrollbarTrackCornerSystemImageMac::create(), cornerRect);
 }