Skip to content

Commit

Permalink
Unreviewed, reverting 279093@main.
Browse files Browse the repository at this point in the history
https://bugs.webkit.org/show_bug.cgi?id=274511

Caused compositing consistency assertion in debug tests

Reverted changeset:

"[view-transitions] Async animation of snapshot position via transform looks jumpy with sync animation of size"
https://bugs.webkit.org/show_bug.cgi?id=274437
https://commits.webkit.org/279093@main

Canonical link: https://commits.webkit.org/279114@main
  • Loading branch information
webkit-commit-queue authored and mattwoodrow committed May 22, 2024
1 parent 05456ae commit 45503f8
Showing 1 changed file with 0 additions and 8 deletions.
8 changes: 0 additions & 8 deletions Source/WebCore/animation/KeyframeEffect.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -2551,14 +2551,6 @@ void KeyframeEffect::computeHasSizeDependentTransform()
{
m_animatesSizeAndSizeDependentTransform = (m_blendingKeyframes.hasWidthDependentTransform() && m_blendingKeyframes.containsProperty(CSSPropertyWidth))
|| (m_blendingKeyframes.hasHeightDependentTransform() && m_blendingKeyframes.containsProperty(CSSPropertyHeight));

// If this is a ::view-transition-group pseudo element with the UA-generated transform
// and width/height animations, then prevent the transform component from being applied
// asynchronously.
if (auto target = targetStyleable()) {
if (target->pseudoElementIdentifier && target->pseudoElementIdentifier->pseudoId == PseudoId::ViewTransitionGroup)
m_animatesSizeAndSizeDependentTransform |= ((m_blendingKeyframes.containsProperty(CSSPropertyWidth) || m_blendingKeyframes.containsProperty(CSSPropertyHeight)) && m_blendingKeyframes.containsProperty(CSSPropertyTransform));
}
}

void KeyframeEffect::effectStackNoLongerPreventsAcceleration()
Expand Down

0 comments on commit 45503f8

Please sign in to comment.