Skip to content

Commit

Permalink
Merge r183941 - Add PLUGIN_ARCHITECTURE(X11) around m_frameRectInWind…
Browse files Browse the repository at this point in the history
…owCoordinates in NetscapePlugin.

https://bugs.webkit.org/show_bug.cgi?id=144490

Patch by Sungmann Cho <sungmann.cho@navercorp.com> on 2015-05-07
Reviewed by Darin Adler.

m_frameRectInWindowCoordinates in NetscapePlugin is currently being used only for
the windowed plugins, and the windowed plugins are only supported on X11. So we can
guard it with PLUGIN_ARCHITECTURE(X11).

No new tests, no behavior change.

* WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
(WebKit::NetscapePlugin::geometryDidChange):
* WebProcess/Plugins/Netscape/NetscapePlugin.h:
  • Loading branch information
chosungmann authored and carlosgcampos committed May 12, 2015
1 parent 6b0c4a9 commit 46b49fc
Show file tree
Hide file tree
Showing 3 changed files with 21 additions and 1 deletion.
17 changes: 17 additions & 0 deletions Source/WebKit2/ChangeLog
@@ -1,3 +1,20 @@
2015-05-07 Sungmann Cho <sungmann.cho@navercorp.com>

Add PLUGIN_ARCHITECTURE(X11) around m_frameRectInWindowCoordinates in NetscapePlugin.
https://bugs.webkit.org/show_bug.cgi?id=144490

Reviewed by Darin Adler.

m_frameRectInWindowCoordinates in NetscapePlugin is currently being used only for
the windowed plugins, and the windowed plugins are only supported on X11. So we can
guard it with PLUGIN_ARCHITECTURE(X11).

No new tests, no behavior change.

* WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
(WebKit::NetscapePlugin::geometryDidChange):
* WebProcess/Plugins/Netscape/NetscapePlugin.h:

2015-05-07 Ada Chan <adachan@apple.com>

Fix a couple of cases where the backForwardListState's currentIndex is not set correctly in WebBackForwardList::backForwardListState().
Expand Down
2 changes: 2 additions & 0 deletions Source/WebKit2/WebProcess/Plugins/Netscape/NetscapePlugin.cpp
Expand Up @@ -759,8 +759,10 @@ void NetscapePlugin::geometryDidChange(const IntSize& pluginSize, const IntRect&
m_clipRect = clipRect;
m_pluginToRootViewTransform = pluginToRootViewTransform;

#if PLUGIN_ARCHITECTURE(X11)
IntPoint frameRectLocationInWindowCoordinates = m_pluginToRootViewTransform.mapPoint(IntPoint());
m_frameRectInWindowCoordinates = IntRect(frameRectLocationInWindowCoordinates, m_pluginSize);
#endif

platformGeometryDidChange();

Expand Down
3 changes: 2 additions & 1 deletion Source/WebKit2/WebProcess/Plugins/Netscape/NetscapePlugin.h
Expand Up @@ -291,8 +291,9 @@ class NetscapePlugin : public Plugin {
// A transform that can be used to convert from root view coordinates to plug-in coordinates.
WebCore::AffineTransform m_pluginToRootViewTransform;

// FIXME: Get rid of these.
#if PLUGIN_ARCHITECTURE(X11)
WebCore::IntRect m_frameRectInWindowCoordinates;
#endif

CString m_userAgent;

Expand Down

0 comments on commit 46b49fc

Please sign in to comment.