Skip to content

Commit

Permalink
Stop using CheckedRef with TypingCommand
Browse files Browse the repository at this point in the history
https://bugs.webkit.org/show_bug.cgi?id=266457

Reviewed by Ryosuke Niwa.

Stop using CheckedRef with TypingCommand. Use WeakRef instead to make
crashes more actionable.

* Source/WebCore/editing/TypingCommand.cpp:
* Source/WebCore/editing/TypingCommand.h:

Canonical link: https://commits.webkit.org/272095@main
  • Loading branch information
cdumez committed Dec 15, 2023
1 parent 1251f3c commit 470d687
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion Source/WebCore/editing/TypingCommand.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ class TypingCommandLineOperation
}

private:
CheckedRef<TypingCommand> m_typingCommand;
WeakRef<TypingCommand> m_typingCommand;
bool m_selectInsertedText;
const String& m_text;
};
Expand Down
2 changes: 1 addition & 1 deletion Source/WebCore/editing/TypingCommand.h
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@

namespace WebCore {

class TypingCommand final : public TextInsertionBaseCommand, public CanMakeCheckedPtr {
class TypingCommand final : public TextInsertionBaseCommand {
public:
enum class Type : uint8_t {
DeleteSelection,
Expand Down

0 comments on commit 470d687

Please sign in to comment.