Inline RenderBoxModelObject::computedCSSPadding()

https://bugs.webkit.org/show_bug.cgi?id=267120 rdar://120510598 Reviewed by Wenson Hsieh and Tim Nguyen. RenderBoxModelObject::computedCSSPadding() is fairly hot on some traces, and not inlined because it was needlessly marked as WEBCORE_EXPORT, so inline it. * Source/WebCore/rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::computedCSSPadding const): Deleted. * Source/WebCore/rendering/RenderBoxModelObject.h: * Source/WebCore/rendering/RenderBoxModelObjectInlines.h: (WebCore::RenderBoxModelObject::computedCSSPadding const): Canonical link: https://commits.webkit.org/272695@main
WebKit · Jan 5, 2024 · 473160f · 473160f
1 parent d579532
commit 473160f
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 9 deletions.
diff --git a/Source/WebCore/rendering/RenderBoxModelObject.cpp b/Source/WebCore/rendering/RenderBoxModelObject.cpp
@@ -650,14 +650,6 @@ LayoutUnit RenderBoxModelObject::offsetTop() const
     return adjustedPositionRelativeToOffsetParent(LayoutPoint()).y();
 }
 
-LayoutUnit RenderBoxModelObject::computedCSSPadding(const Length& padding) const
-{
-    LayoutUnit w;
-    if (padding.isPercentOrCalculated())
-        w = containingBlockLogicalWidthForContent();
-    return minimumValueForLength(padding, w);
-}
-
 InterpolationQuality RenderBoxModelObject::chooseInterpolationQuality(GraphicsContext& context, Image& image, const void* layer, const LayoutSize& size) const
 {
     return view().imageQualityController().chooseInterpolationQuality(context, const_cast<RenderBoxModelObject*>(this), image, layer, size);

diff --git a/Source/WebCore/rendering/RenderBoxModelObject.h b/Source/WebCore/rendering/RenderBoxModelObject.h
@@ -259,7 +259,7 @@ class RenderBoxModelObject : public RenderLayerModelObject {
     ContinuationChainNode* continuationChainNode() const;
 
 protected:
-    WEBCORE_EXPORT LayoutUnit computedCSSPadding(const Length&) const;
+    LayoutUnit computedCSSPadding(const Length&) const;
     virtual void absoluteQuadsIgnoringContinuation(const FloatRect&, Vector<FloatQuad>&, bool* /*wasFixed*/) const { ASSERT_NOT_REACHED(); }
     void collectAbsoluteQuadsForContinuation(Vector<FloatQuad>& quads, bool* wasFixed) const;
 

diff --git a/Source/WebCore/rendering/RenderBoxModelObjectInlines.h b/Source/WebCore/rendering/RenderBoxModelObjectInlines.h
@@ -78,4 +78,12 @@ inline LayoutSize RenderBoxModelObject::stickyPositionLogicalOffset() const { re
 inline LayoutUnit RenderBoxModelObject::verticalBorderAndPaddingExtent() const { return borderTop() + borderBottom() + paddingTop() + paddingBottom(); }
 inline LayoutUnit RenderBoxModelObject::verticalBorderExtent() const { return borderTop() + borderBottom(); }
 
+inline LayoutUnit RenderBoxModelObject::computedCSSPadding(const Length& padding) const
+{
+    LayoutUnit containerWidth;
+    if (padding.isPercentOrCalculated())
+        containerWidth = containingBlockLogicalWidthForContent();
+    return minimumValueForLength(padding, containerWidth);
+}
+
 } // namespace WebCore