Skip to content

Commit

Permalink
Merge r241732 - Web Inspector: duplicate left double quotation mark (…
Browse files Browse the repository at this point in the history
…\u201C) in 'Unable to show certificate for “%s“.'

https://bugs.webkit.org/show_bug.cgi?id=194782
<rdar://problem/48159683>

Reviewed by Joseph Pecoraro.

* UserInterface/Models/Resource.js:
(WI.Resource.prototype.async showCertificate):
* Localizations/en.lproj/localizedStrings.js:
  • Loading branch information
dcrousso authored and carlosgcampos committed Feb 20, 2019
1 parent a2ea5a9 commit 4799f10
Show file tree
Hide file tree
Showing 3 changed files with 15 additions and 3 deletions.
12 changes: 12 additions & 0 deletions Source/WebInspectorUI/ChangeLog
@@ -1,3 +1,15 @@
2019-02-18 Devin Rousso <drousso@apple.com>

Web Inspector: duplicate left double quotation mark (\u201C) in 'Unable to show certificate for “%s“.'
https://bugs.webkit.org/show_bug.cgi?id=194782
<rdar://problem/48159683>

Reviewed by Joseph Pecoraro.

* UserInterface/Models/Resource.js:
(WI.Resource.prototype.async showCertificate):
* Localizations/en.lproj/localizedStrings.js:

2019-02-17 Matt Baker <mattbaker@apple.com>

Web Inspector: Frontend performance is very slow reloading theverge.com - 50% of time in TreeOutline _indexOfTreeElement
Expand Down
Expand Up @@ -371,6 +371,7 @@ localizedStrings["Element is the root element"] = "Element is the root element";
localizedStrings["Element may overlap another compositing element"] = "Element may overlap another compositing element";
localizedStrings["Element overlaps other compositing element"] = "Element overlaps other compositing element";
localizedStrings["Elements"] = "Elements";
localizedStrings["Emulate User Gesture"] = "Emulate User Gesture";
localizedStrings["Enable Breakpoint"] = "Enable Breakpoint";
localizedStrings["Enable Breakpoints"] = "Enable Breakpoints";
localizedStrings["Enable Changes Panel"] = "Enable Changes Panel";
Expand Down Expand Up @@ -460,7 +461,6 @@ localizedStrings["Format: RGB"] = "Format: RGB";
localizedStrings["Format: RGBA"] = "Format: RGBA";
localizedStrings["Format: Short Hex"] = "Format: Short Hex";
localizedStrings["Format: Short Hex with Alpha"] = "Format: Short Hex with Alpha";
localizedStrings["Forms"] = "Forms";
localizedStrings["Forward (%s)"] = "Forward (%s)";
localizedStrings["Fragment"] = "Fragment";
localizedStrings["Fragment Shader"] = "Fragment Shader";
Expand Down Expand Up @@ -1021,7 +1021,7 @@ localizedStrings["URL"] = "URL";
localizedStrings["URL Breakpoint\u2026"] = "URL Breakpoint\u2026";
localizedStrings["Unable to determine path to property from root"] = "Unable to determine path to property from root";
localizedStrings["Unable to parse as JSON: %s"] = "Unable to parse as JSON: %s";
localizedStrings["Unable to show certificate for \u201C%s\u201C"] = "Unable to show certificate for \u201C%s\u201C";
localizedStrings["Unable to show certificate for \u201C%s\u201D"] = "Unable to show certificate for \u201C%s\u201D";
localizedStrings["Uncaught Exceptions"] = "Uncaught Exceptions";
localizedStrings["Undefined custom element"] = "Undefined custom element";
localizedStrings["Unique"] = "Unique";
Expand Down
2 changes: 1 addition & 1 deletion Source/WebInspectorUI/UserInterface/Models/Resource.js
Expand Up @@ -1111,7 +1111,7 @@ WI.Resource = class Resource extends WI.SourceCode

async showCertificate()
{
let errorString = WI.UIString("Unable to show certificate for \u201C%s\u201C").format(this.url);
let errorString = WI.UIString("Unable to show certificate for \u201C%s\u201D").format(this.url);

try {
let {serializedCertificate} = await NetworkAgent.getSerializedCertificate(this._requestIdentifier);
Expand Down

0 comments on commit 4799f10

Please sign in to comment.