Skip to content

Commit

Permalink
Cherry-pick 14f4676. rdar://problem/107352115
Browse files Browse the repository at this point in the history
    Regression(259658@main) Geolocation permission prompt is no longer showing in modal view
    https://bugs.webkit.org/show_bug.cgi?id=255133
    rdar://107352115

    Reviewed by Wenson Hsieh and Tim Horton.

    Use the same view controller to present the prompt as the UIWebView code used to.
    I have verified locally that this fixes the issue.

    * Source/WebKit/UIProcess/ios/WKWebGeolocationPolicyDeciderIOS.mm:
    (-[WKWebGeolocationPolicyDecider _executeNextChallenge]):

    Canonical link: https://commits.webkit.org/262697@main

Identifier: 259548.664@safari-7615.2.9.13-branch
  • Loading branch information
cdumez authored and drobson1005 committed Apr 21, 2023
1 parent a20b8eb commit 487d3d0
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -196,7 +196,7 @@ - (void)_executeNextChallenge
[alert addAction:denyAction];
[alert addAction:allowAction];

[[_activeChallenge->view window].rootViewController presentViewController:alert animated:YES completion:nil];
[[UIViewController _viewControllerForFullScreenPresentationFromView:_activeChallenge->view.get()] presentViewController:alert animated:YES completion:nil];
}];
}

Expand Down

0 comments on commit 487d3d0

Please sign in to comment.