Skip to content

Commit

Permalink
REGRESSION(271265@main): Heap corruption crash while destructing WebG…
Browse files Browse the repository at this point in the history
…LMultiDraw

https://bugs.webkit.org/show_bug.cgi?id=265538

Unreviewed crash fix for Windows port.
Windows port was crashing after 271265@main made WebGLExtension a
RefCounted subclass. Only WebGLMultiDraw has virtual destructor among
WebGLExtension subclasses. ~WebGLMultiDraw should be non-virtual as
well as other WebGLExtension subclasses.

* Source/WebCore/html/canvas/WebGLMultiDraw.h:
Removed virtual from ~WebGLMultiDraw.

Canonical link: https://commits.webkit.org/271315@main
  • Loading branch information
fujii committed Nov 30, 2023
1 parent 8607642 commit 48c1a4c
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion Source/WebCore/html/canvas/WebGLMultiDraw.h
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ class WebGLMultiDraw final : public WebGLExtension<WebGLRenderingContextBase> {
using Int32List = WebGLRenderingContextBase::TypedList<Int32Array, int32_t>;

explicit WebGLMultiDraw(WebGLRenderingContextBase&);
virtual ~WebGLMultiDraw();
~WebGLMultiDraw();

static bool supported(GraphicsContextGL&);

Expand Down

0 comments on commit 48c1a4c

Please sign in to comment.