Skip to content

Commit

Permalink
Merge r180938 - [Win64] JSC compile error.
Browse files Browse the repository at this point in the history
https://bugs.webkit.org/show_bug.cgi?id=142216

Patch by peavo@outlook.com <peavo@outlook.com> on 2015-03-03
Reviewed by Mark Lam.

There is missing a version of setupArgumentsWithExecState when NUMBER_OF_ARGUMENT_REGISTERS == 4.

* jit/CCallHelpers.h:
(JSC::CCallHelpers::setupArgumentsWithExecState):
  • Loading branch information
peavo authored and carlosgcampos committed Mar 8, 2015
1 parent 3f23cba commit 48c8dfd
Show file tree
Hide file tree
Showing 2 changed files with 19 additions and 0 deletions.
12 changes: 12 additions & 0 deletions Source/JavaScriptCore/ChangeLog
@@ -1,3 +1,15 @@
2015-03-03 peavo@outlook.com <peavo@outlook.com>

[Win64] JSC compile error.
https://bugs.webkit.org/show_bug.cgi?id=142216

Reviewed by Mark Lam.

There is missing a version of setupArgumentsWithExecState when NUMBER_OF_ARGUMENT_REGISTERS == 4.

* jit/CCallHelpers.h:
(JSC::CCallHelpers::setupArgumentsWithExecState):

2015-02-26 Mark Lam <mark.lam@apple.com>

MachineThreads::Thread clean up has a use after free race condition.
Expand Down
7 changes: 7 additions & 0 deletions Source/JavaScriptCore/jit/CCallHelpers.h
Expand Up @@ -1735,6 +1735,13 @@ class CCallHelpers : public AssemblyHelpers {
move(arg3, GPRInfo::argumentGPR2);
move(arg4, GPRInfo::argumentGPR3);
}

ALWAYS_INLINE void setupArgumentsWithExecState(TrustedImm32 arg1, GPRReg arg2, TrustedImm32 arg3, GPRReg arg4, TrustedImm32 arg5)
{
poke(arg5, POKE_ARGUMENT_OFFSET + 1);
poke(arg4, POKE_ARGUMENT_OFFSET);
setupArgumentsWithExecState(arg1, arg2, arg3);
}
#endif // NUMBER_OF_ARGUMENT_REGISTERS == 4

#if NUMBER_OF_ARGUMENT_REGISTERS >= 5
Expand Down

0 comments on commit 48c8dfd

Please sign in to comment.