Skip to content

Commit

Permalink
[PlayStation] Enable variation fonts experimentally
Browse files Browse the repository at this point in the history
https://bugs.webkit.org/show_bug.cgi?id=260987

Reviewed by Fujii Hironori.

Check the versions of freetype, harfbuzz and fontconfig to see if its
possible to turn on `ENABLE_VARIATION_FONTS`.

* Source/cmake/OptionsPlayStation.cmake:

Canonical link: https://commits.webkit.org/267533@main
  • Loading branch information
donny-dont committed Sep 1, 2023
1 parent 0756854 commit 4d0e5ae
Showing 1 changed file with 7 additions and 3 deletions.
10 changes: 7 additions & 3 deletions Source/cmake/OptionsPlayStation.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -199,6 +199,13 @@ if (USE_WPE_BACKEND_PLAYSTATION)
WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_GAMEPAD PRIVATE ${ENABLE_EXPERIMENTAL_FEATURES})
endif ()

# Enable variation fonts when cairo >= 1.16, fontconfig >= 2.13.0, freetype >= 2.9.0 and harfbuzz >= 1.4.2
if (Cairo_VERSION VERSION_GREATER_EQUAL 1.16.0 AND Fontconfig_VERSION VERSION_GREATER_EQUAL 2.13.0 AND FREETYPE_VERSION_STRING VERSION_GREATER_EQUAL 2.9.0 AND HarfBuzz_VERSION VERSION_GREATER_EQUAL 1.4.2)
WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_VARIATION_FONTS PRIVATE ${ENABLE_EXPERIMENTAL_FEATURES})
else ()
WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_VARIATION_FONTS PRIVATE OFF)
endif ()

# Features to investigate
#
# Features that require additional implementation pieces
Expand All @@ -211,9 +218,6 @@ WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_ASYNC_SCROLLING PRIVATE OFF)
WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_GPU_PROCESS PRIVATE OFF)
WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_WEB_AUDIO PRIVATE OFF)

# Reenable after updating fontconfig
WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_VARIATION_FONTS PRIVATE OFF)

# Enable in the future
WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_CONTEXT_MENUS PRIVATE OFF)

Expand Down

0 comments on commit 4d0e5ae

Please sign in to comment.