Skip to content

Commit

Permalink
[Xcode] Make-based builds unnecessarily override PATH
Browse files Browse the repository at this point in the history
https://bugs.webkit.org/show_bug.cgi?id=265609
rdar://16466196

Reviewed by Alexey Proskuryakov.

Since https://commits.webkit.org/164487@main, we pass
UseSanitizedBuildSystemEnvironment=YES to Xcode, which causes it to use
a well-defined PATH. Additionally, rdar://16466196 made Xcode more
resilient to rebuilds where the PATH changes.

Remove the override.

* Makefile.shared:

Canonical link: https://commits.webkit.org/271362@main
  • Loading branch information
emw-apple committed Dec 1, 2023
1 parent 8796ae7 commit 4d6ae57
Showing 1 changed file with 0 additions and 5 deletions.
5 changes: 0 additions & 5 deletions Makefile.shared
Original file line number Diff line number Diff line change
Expand Up @@ -131,11 +131,6 @@ endif

export DSYMUTIL_NUM_THREADS = $(shell sysctl -n hw.activecpu)

# Run xcodebuild with the same PATH with which the Xcode IDE runs, to mitigate unnecessary rebuilds due to PATH differences.
# See <rdar://problem/16466196>.
export PATH = $(shell getconf PATH)


define set_webkit_configuration
$(SCRIPTS_PATH)/set-webkit-configuration $1 $(CONFIG_OPTIONS)
endef
Expand Down

0 comments on commit 4d6ae57

Please sign in to comment.