Skip to content

Commit

Permalink
Merge r220581 - [Soup] Do not spawn the network process to setup cook…
Browse files Browse the repository at this point in the history
…ie persistent storage

https://bugs.webkit.org/show_bug.cgi?id=175424

Reviewed by Sergio Villar Senin.

The persistent storage configuration is saved and passed to network process as creation parameters, so we don't
need to spawn the network process to configure it, when it's created eventually it will use the configuration.

* UIProcess/soup/WebCookieManagerProxySoup.cpp:
(WebKit::WebCookieManagerProxy::setCookiePersistentStorage): Use sendToNetworkingProcess() instead of
endToNetworkingProcessRelaunchingIfNecessary().
  • Loading branch information
carlosgcampos committed Aug 14, 2017
1 parent 10f7b98 commit 4f94b54
Show file tree
Hide file tree
Showing 2 changed files with 15 additions and 2 deletions.
14 changes: 14 additions & 0 deletions Source/WebKit/ChangeLog
@@ -1,3 +1,17 @@
2017-08-10 Carlos Garcia Campos <cgarcia@igalia.com>

[Soup] Do not spawn the network process to setup cookie persistent storage
https://bugs.webkit.org/show_bug.cgi?id=175424

Reviewed by Sergio Villar Senin.

The persistent storage configuration is saved and passed to network process as creation parameters, so we don't
need to spawn the network process to configure it, when it's created eventually it will use the configuration.

* UIProcess/soup/WebCookieManagerProxySoup.cpp:
(WebKit::WebCookieManagerProxy::setCookiePersistentStorage): Use sendToNetworkingProcess() instead of
endToNetworkingProcessRelaunchingIfNecessary().

2017-08-10 Carlos Garcia Campos <cgarcia@igalia.com>

[GTK][WPE] Assertion failure in TimerBase inside WebCore::IconRecord::setImageData
Expand Down
3 changes: 1 addition & 2 deletions Source/WebKit/UIProcess/soup/WebCookieManagerProxySoup.cpp
Expand Up @@ -33,10 +33,9 @@ namespace WebKit {

void WebCookieManagerProxy::setCookiePersistentStorage(const String& storagePath, uint32_t storageType)
{
processPool()->sendToNetworkingProcessRelaunchingIfNecessary(Messages::WebCookieManager::SetCookiePersistentStorage(storagePath, storageType));

m_cookiePersistentStoragePath = storagePath;
m_cookiePersistentStorageType = static_cast<SoupCookiePersistentStorageType>(storageType);
processPool()->sendToNetworkingProcess(Messages::WebCookieManager::SetCookiePersistentStorage(storagePath, storageType));
}

void WebCookieManagerProxy::getCookiePersistentStorage(String& storagePath, uint32_t& storageType) const
Expand Down

0 comments on commit 4f94b54

Please sign in to comment.