Skip to content

Commit

Permalink
Fix the build when using libwebrtc
Browse files Browse the repository at this point in the history
Unreviewed build fixes.

* Source/ThirdParty/libwebrtc/CMakeLists.txt: Set the CXX_STANDARD
property on the webrtc target to use C++17, as required by some part
of libabseil.
* Source/ThirdParty/libwebrtc/Source/webrtc/modules/rtp_rtcp/source/rtcp_transceiver_impl.cc:
Add missing include for <optional>.

Canonical link: https://commits.webkit.org/266719.356@webkitglib/2.42
  • Loading branch information
aperezdc committed Mar 14, 2024
1 parent d121f66 commit 53c8c77
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
2 changes: 1 addition & 1 deletion Source/ThirdParty/libwebrtc/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -2034,12 +2034,12 @@ endif ()
add_library(webrtc STATIC ${webrtc_SOURCES})

target_compile_options(webrtc PRIVATE
"$<$<COMPILE_LANGUAGE:CXX>:-std=gnu++11>"
"-UHAVE_CONFIG_H"
"-DWEBRTC_WEBKIT_BUILD=1"
"-w"
)

set_target_properties(webrtc PROPERTIES CXX_STANDARD 17)
set_target_properties(webrtc PROPERTIES CXX_VISIBILITY_PRESET hidden)
set_target_properties(webrtc PROPERTIES C_VISIBILITY_PRESET hidden)

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@

#include <algorithm>
#include <utility>
#include <optional>

#include "absl/algorithm/container.h"
#include "absl/memory/memory.h"
Expand Down

0 comments on commit 53c8c77

Please sign in to comment.