Skip to content

Commit

Permalink
postprocess-asm rule doesn't respect RUBY_EXECUTABLE
Browse files Browse the repository at this point in the history
https://bugs.webkit.org/show_bug.cgi?id=254965

Reviewed by Yusuke Suzuki.

postprocess-asm is a Ruby script with #/!/usr/bin/env ruby as its shebang which
looks up Ruby in PATH. webkit, however, has RUBY_EXECUTABLE as a CMake option.
It's possible for the Ruby used by CMake (and the other rules during the build)
to be different to the first Ruby found in PATH. This makes the usage for postprocess-asm
consistent with other uses in webkit.

* Source/JavaScriptCore/CMakeLists.txt

Canonical link: https://commits.webkit.org/262719@main
  • Loading branch information
thesamesam authored and Constellation committed Apr 7, 2023
1 parent 3b5080a commit 546b711
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion Source/JavaScriptCore/CMakeLists.txt
Expand Up @@ -1507,7 +1507,7 @@ endif ()
if (CMAKE_COMPILER_IS_GNUCXX AND GCC_OFFLINEASM_SOURCE_MAP)
message(STATUS "Enabling asm postprocessing")

set(LowLevelInterpreter_LAUNCHER "${JavaScriptCore_SCRIPTS_SOURCES_DIR}/postprocess-asm")
set(LowLevelInterpreter_LAUNCHER "${RUBY_EXECUTABLE} ${JavaScriptCore_SCRIPTS_SOURCES_DIR}/postprocess-asm")
get_target_property(PROP_RULE_LAUNCH_COMPILE LowLevelInterpreterLib RULE_LAUNCH_COMPILE)
if (PROP_RULE_LAUNCH_COMPILE)
set(LowLevelInterpreter_LAUNCHER "${LowLevelInterpreter_LAUNCHER} ${PROP_RULE_LAUNCH_COMPILE}")
Expand Down

0 comments on commit 546b711

Please sign in to comment.