Skip to content

Commit

Permalink
Re-enable http/tests/site-isolation/basic-iframe.html on macOS
Browse files Browse the repository at this point in the history
https://bugs.webkit.org/show_bug.cgi?id=260720
rdar://114460209

Unreviewed test gardening.

After 267270@main it passes on macOS with a fuzzy diff around the border of the iframe.
It still times out on iOS for an unknown reason that can be investigated later.
Re-enable the test on macOS so we can notice any future regressions.

* LayoutTests/TestExpectations:
* LayoutTests/http/tests/site-isolation/basic-iframe.html:
* LayoutTests/platform/ios/TestExpectations:

Canonical link: https://commits.webkit.org/267296@main
  • Loading branch information
achristensen07 committed Aug 25, 2023
1 parent f46ead2 commit 5667e62
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 2 deletions.
2 changes: 0 additions & 2 deletions LayoutTests/TestExpectations
Original file line number Diff line number Diff line change
Expand Up @@ -6584,8 +6584,6 @@ imported/w3c/web-platform-tests/css/css-overflow/overflow-auto-scrollbar-gutter-

webkit.org/b/257336 imported/w3c/web-platform-tests/css/css-tables/visibility-collapse-row-003-dynamic.html [ Pass Failure ]

webkit.org/b/257904 http/tests/site-isolation/basic-iframe.html [ Skip ]

# Only some OSes have support for auto word breaking.
imported/w3c/web-platform-tests/css/css-text/word-break/auto [ Pass Failure ImageOnlyFailure ]

Expand Down
1 change: 1 addition & 0 deletions LayoutTests/http/tests/site-isolation/basic-iframe.html
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
<!-- webkit-test-runner [ SiteIsolationEnabled=true ] -->
<head><meta name="fuzzy" content="maxDifference=112; totalPixels=900"/></head>
<body bgcolor=blue>
<iframe src="http://localhost:8000/site-isolation/resources/green-background.html" frameborder=0></iframe>
</body>
2 changes: 2 additions & 0 deletions LayoutTests/platform/ios/TestExpectations
Original file line number Diff line number Diff line change
Expand Up @@ -4587,3 +4587,5 @@ webkit.org/b/260310 imported/w3c/web-platform-tests/css/cssom-view/scrollIntoVie
imported/w3c/web-platform-tests/css/css-lists/list-style-image-gradients-dynamic.html [ Skip ]
imported/w3c/web-platform-tests/css/css-lists/list-style-image-gradients.html [ Skip ]
imported/w3c/web-platform-tests/css/css-lists/content-property/marker-text-matches-disc.html [ Skip ]

webkit.org/b/257904 http/tests/site-isolation/basic-iframe.html [ Skip ]

0 comments on commit 5667e62

Please sign in to comment.