Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
https://bugs.webkit.org/show_bug.cgi?id=117769 Reviewed by Simon Fraser. Source/WebCore: This doesn't simplify the code so much yet but makes the CSS properties not accessible by web content, which means that how marquee is implemented is now an implementation detail that WebKit can change. Had to keep some of parsing code because addHTMLLengthToStyle uses the CSS parser, which is a bit unfortunate. But we can avoid dealing with identifiers so it can be simplified a bit, and similarly we can avoid having a shorthand altogether. Covered by existing tests that are being modified to reflect the change. * css/CSSComputedStyleDeclaration.cpp: (WebCore::ComputedStyleExtractor::valueForPropertyInStyle): * css/CSSProperties.json: * css/StyleProperties.cpp: (WebCore::StyleProperties::getPropertyValue const): * css/parser/CSSPropertyParser.cpp: (WebCore::CSSPropertyParser::parseSingleValue): (WebCore::CSSPropertyParser::parseShorthand): Source/WebInspectorUI: * UserInterface/Models/CSSKeywordCompletions.js: LayoutTests: * fast/css/getComputedStyle/computed-style-expected.txt: * fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: * fast/css/getComputedStyle/getComputedStyle-length-unit-expected.txt: * fast/css/getComputedStyle/getComputedStyle-length-unit.html: * fast/css/getComputedStyle/getComputedStyle-zoom-and-background-size-expected.txt: * fast/css/getComputedStyle/getComputedStyle-zoom-and-background-size.html: * fast/css/getComputedStyle/resources/property-names.js: * fast/css/getPropertyValue-webkit-marquee-expected.txt: Removed. * fast/css/getPropertyValue-webkit-marquee.html: Removed. * fast/css/inherit-initial-shorthand-values-expected.txt: * fast/css/inherit-initial-shorthand-values.html: * fast/css/remove-shorthand-expected.txt: * fast/css/remove-shorthand.html: * legacy-animation-engine/fast/css/getComputedStyle/resources/property-names.js: * platform/gtk/fast/css/getComputedStyle/computed-style-expected.txt: * platform/gtk/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: * platform/gtk/svg/css/getComputedStyle-basic-expected.txt: * platform/ios/fast/css/getComputedStyle/computed-style-expected.txt: * platform/ios/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: * platform/ios/svg/css/getComputedStyle-basic-expected.txt: * platform/mac/fast/css/getComputedStyle/computed-style-expected.txt: * platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: * platform/mac/svg/css/getComputedStyle-basic-expected.txt: * platform/wpe/fast/css/getComputedStyle/computed-style-expected.txt: * platform/wpe/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: * platform/wpe/svg/css/getComputedStyle-basic-expected.txt: * svg/css/getComputedStyle-basic-expected.txt: Canonical link: https://commits.webkit.org/218456@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@253540 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- Loading branch information
Showing
36 changed files
with
96 additions
and
325 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
25 changes: 0 additions & 25 deletions
25
LayoutTests/fast/css/getPropertyValue-webkit-marquee-expected.txt
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.