Skip to content

Commit

Permalink
[Skia] Test css3/filters/svg-blur-filter-clipped.html is failing
Browse files Browse the repository at this point in the history
https://bugs.webkit.org/show_bug.cgi?id=274303

Reviewed by Carlos Garcia Campos.

This change fixes a skia gaussian blur filter applier which was not drawing the result on
correct position in some cases.

* LayoutTests/platform/glib/TestExpectations:
* Source/WebCore/platform/graphics/filters/skia/FEGaussianBlurSkiaApplier.cpp:
(WebCore::FEGaussianBlurSkiaApplier::apply const):

Canonical link: https://commits.webkit.org/278986@main
  • Loading branch information
Scony authored and carlosgcampos committed May 20, 2024
1 parent c0ceacd commit 57cf11d
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 7 deletions.
5 changes: 0 additions & 5 deletions LayoutTests/platform/glib/TestExpectations
Original file line number Diff line number Diff line change
Expand Up @@ -1540,7 +1540,6 @@ svg/animations/animateMotion-additive-2a.svg [ ImageOnlyFailure ]
svg/animations/animateMotion-additive-2c.svg [ ImageOnlyFailure ]
svg/as-image/svg-image-with-data-uri-from-canvas.html [ ImageOnlyFailure ]
svg/filters/feDiffuseLighting-feSpotLight-dynamic-update.svg [ ImageOnlyFailure ]
svg/filters/feGaussianBlur-clipped.svg [ ImageOnlyFailure ]
svg/filters/feSpecularLighting-fePointLight-dynamic-update.svg [ ImageOnlyFailure ]
svg/masking/mask-transformed-text-missing.svg [ ImageOnlyFailure ]
svg/text/tspan-outline.html [ ImageOnlyFailure ]
Expand All @@ -1551,10 +1550,6 @@ svg/zoom/page/text-with-non-scaling-stroke.html [ ImageOnlyFailure ]
webkit.org/b/273396 css3/background/background-repeat-space-content.html [ ImageOnlyFailure ]
webkit.org/b/273396 css3/color-filters/color-filter-color-text-decorations.html [ ImageOnlyFailure ]
webkit.org/b/273396 css3/color-filters/color-filter-text-decoration-shadow.html [ ImageOnlyFailure ]
webkit.org/b/273396 css3/filters/effect-blur-hw.html [ ImageOnlyFailure ]
webkit.org/b/273396 css3/filters/effect-blur.html [ ImageOnlyFailure ]
webkit.org/b/273396 css3/filters/effect-combined.html [ ImageOnlyFailure ]
webkit.org/b/273396 css3/filters/svg-blur-filter-clipped.html [ ImageOnlyFailure ]
webkit.org/b/273396 css3/masking/clip-path-border-radius-border-box-000.html [ ImageOnlyFailure ]
webkit.org/b/273396 css3/masking/clip-path-border-radius-content-box-001.html [ ImageOnlyFailure ]
webkit.org/b/273396 css3/masking/clip-path-border-radius-fill-box-001.html [ ImageOnlyFailure ]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -53,12 +53,12 @@ bool FEGaussianBlurSkiaApplier::apply(const Filter& filter, const FilterImageVec
return false;

FloatSize sigma = FloatSize(m_effect.stdDeviationX(), m_effect.stdDeviationY()) * filter.filterScale();
auto outsetSize = m_effect.calculateOutsetSize(sigma);

SkPaint paint;
paint.setImageFilter(SkImageFilters::Blur(sigma.width(), sigma.height(), nullptr));

resultImage->context().platformContext()->drawImage(nativeImage->platformImage(), outsetSize.width(), outsetSize.height(), { }, &paint);
auto inputOffsetWithinResult = input.absoluteImageRectRelativeTo(result).location();
resultImage->context().platformContext()->drawImage(nativeImage->platformImage(), inputOffsetWithinResult.x(), inputOffsetWithinResult.y(), { }, &paint);
return true;
}

Expand Down

0 comments on commit 57cf11d

Please sign in to comment.