Skip to content

Commit

Permalink
Cherry-pick a41543c. rdar://problem/113271473
Browse files Browse the repository at this point in the history
    InputDevice capabilities are not required until capture is active
    https://bugs.webkit.org/show_bug.cgi?id=259814
    rdar://113271473

    Reviewed by Jer Noble.

    InputDevice capabilities are not exposed until after the user has given consent to
    capture, so don't bother asking for them unless they will be revealed as activating the
    AVAudioSession may change the characteristics of the audio rendering in other processes.

    * Source/WebKit/UIProcess/UserMediaPermissionRequestManagerProxy.cpp:
    (WebKit::UserMediaPermissionRequestManagerProxy::platformGetMediaStreamDevices):

    Canonical link: https://commits.webkit.org/266581@main

Identifier: 265870.299@safari-7616.1.27.10-branch
  • Loading branch information
eric-carlson authored and rjepstein committed Aug 4, 2023
1 parent ff4f94c commit 5b0eda9
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -819,7 +819,7 @@ void UserMediaPermissionRequestManagerProxy::platformGetMediaStreamDevices(bool
for (auto& device : devices) {
RealtimeMediaSourceCapabilities deviceCapabilities;

if (device.isInputDevice()) {
if (revealIdsAndLabels && device.isInputDevice()) {
auto capabilities = RealtimeMediaSourceCenter::singleton().getCapabilities(device);
if (!capabilities)
continue;
Expand Down

0 comments on commit 5b0eda9

Please sign in to comment.