Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
CSS Keywords should be lowercased during serialization
https://bugs.webkit.org/show_bug.cgi?id=249438 Reviewed by Sam Weinig. CSS Keywords should be lowercased during serialization: - https://www.w3.org/TR/cssom-1/#serialize-a-css-component-value * LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/color-interpolation-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/pointer-events-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/shape-rendering-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/text-rendering-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-variables/variable-presentation-attribute-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/filter-effects/inheritance-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/filter-effects/parsing/color-interpolation-filters-computed-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/filter-effects/parsing/color-interpolation-filters-parsing-valid-expected.txt: Rebaseline WPT tests now that more checks are passing. * Source/WebCore/css/CSSPrimitiveValue.cpp: (WebCore::CSSPrimitiveValue::formatNumberForCustomCSSText const): Call nameStringForSerialization() instead of nameString() since we are serializing. This makes sure that the identifier is serialized as lowercase. * Source/WebCore/css/typedom/CSSStyleValueFactory.cpp: (WebCore::CSSStyleValueFactory::reifyValue): Per https://drafts.css-houdini.org/css-typed-om-1/#reify-ident, we should create a CSSKeywordValue from the *serialization* of the identifier, which means that the identifier would become lowercase. * Source/WebCore/css/process-css-values.py: (GenerationContext): Generate nameStringForSerialization() which provides the name string of the keyword as lowercase, for the purpose of serialization. Canonical link: https://commits.webkit.org/258024@main
- Loading branch information
Showing
29 changed files
with
109 additions
and
71 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 changes: 2 additions & 2 deletions
4
LayoutTests/imported/w3c/web-platform-tests/css/filter-effects/inheritance-expected.txt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 changes: 2 additions & 2 deletions
4
...atform-tests/css/filter-effects/parsing/color-interpolation-filters-computed-expected.txt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,5 @@ | ||
|
||
PASS Property color-interpolation-filters value 'auto' | ||
FAIL Property color-interpolation-filters value 'srgb' assert_equals: expected "srgb" but got "sRGB" | ||
FAIL Property color-interpolation-filters value 'linearrgb' assert_equals: expected "linearrgb" but got "linearRGB" | ||
PASS Property color-interpolation-filters value 'srgb' | ||
PASS Property color-interpolation-filters value 'linearrgb' | ||
|
6 changes: 3 additions & 3 deletions
6
...m-tests/css/filter-effects/parsing/color-interpolation-filters-parsing-valid-expected.txt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,6 @@ | ||
|
||
PASS e.style['color-interpolation-filters'] = "auto" should set the property value | ||
FAIL e.style['color-interpolation-filters'] = "sRGB" should set the property value assert_equals: serialization should be canonical expected "srgb" but got "sRGB" | ||
FAIL e.style['color-interpolation-filters'] = "linearRGB" should set the property value assert_equals: serialization should be canonical expected "linearrgb" but got "linearRGB" | ||
FAIL e.style['color-interpolation-filters'] = "LiNeArRgB" should set the property value assert_equals: serialization should be canonical expected "linearrgb" but got "linearRGB" | ||
PASS e.style['color-interpolation-filters'] = "sRGB" should set the property value | ||
PASS e.style['color-interpolation-filters'] = "linearRGB" should set the property value | ||
PASS e.style['color-interpolation-filters'] = "LiNeArRgB" should set the property value | ||
|
6 changes: 3 additions & 3 deletions
6
...ts/imported/w3c/web-platform-tests/svg/interact/parsing/pointer-events-valid-expected.txt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 changes: 2 additions & 2 deletions
4
...ted/w3c/web-platform-tests/svg/painting/parsing/color-interpolation-computed-expected.txt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,5 @@ | ||
|
||
PASS Property color-interpolation value 'auto' | ||
FAIL Property color-interpolation value 'srgb' assert_equals: expected "srgb" but got "sRGB" | ||
FAIL Property color-interpolation value 'linearrgb' assert_equals: expected "linearrgb" but got "linearRGB" | ||
PASS Property color-interpolation value 'srgb' | ||
PASS Property color-interpolation value 'linearrgb' | ||
|
4 changes: 2 additions & 2 deletions
4
...mported/w3c/web-platform-tests/svg/painting/parsing/image-rendering-computed-expected.txt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,5 @@ | ||
|
||
PASS Property image-rendering value 'auto' | ||
FAIL Property image-rendering value 'optimizequality' assert_equals: expected "optimizequality" but got "optimizeQuality" | ||
FAIL Property image-rendering value 'optimizespeed' assert_equals: expected "optimizespeed" but got "optimizeSpeed" | ||
PASS Property image-rendering value 'optimizequality' | ||
PASS Property image-rendering value 'optimizespeed' | ||
|
4 changes: 2 additions & 2 deletions
4
...s/imported/w3c/web-platform-tests/svg/painting/parsing/image-rendering-valid-expected.txt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,5 @@ | ||
|
||
PASS e.style['image-rendering'] = "auto" should set the property value | ||
FAIL e.style['image-rendering'] = "optimizequality" should set the property value assert_equals: serialization should be canonical expected "optimizequality" but got "optimizeQuality" | ||
FAIL e.style['image-rendering'] = "optimizespeed" should set the property value assert_equals: serialization should be canonical expected "optimizespeed" but got "optimizeSpeed" | ||
PASS e.style['image-rendering'] = "optimizequality" should set the property value | ||
PASS e.style['image-rendering'] = "optimizespeed" should set the property value | ||
|
4 changes: 2 additions & 2 deletions
4
...mported/w3c/web-platform-tests/svg/painting/parsing/shape-rendering-computed-expected.txt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,6 @@ | ||
|
||
PASS Property shape-rendering value 'auto' | ||
FAIL Property shape-rendering value 'optimizespeed' assert_equals: expected "optimizespeed" but got "optimizeSpeed" | ||
PASS Property shape-rendering value 'optimizespeed' | ||
PASS Property shape-rendering value 'crispedges' | ||
FAIL Property shape-rendering value 'geometricprecision' assert_equals: expected "geometricprecision" but got "geometricPrecision" | ||
PASS Property shape-rendering value 'geometricprecision' | ||
|
4 changes: 2 additions & 2 deletions
4
...s/imported/w3c/web-platform-tests/svg/painting/parsing/shape-rendering-valid-expected.txt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,6 @@ | ||
|
||
PASS e.style['shape-rendering'] = "auto" should set the property value | ||
FAIL e.style['shape-rendering'] = "optimizespeed" should set the property value assert_equals: serialization should be canonical expected "optimizespeed" but got "optimizeSpeed" | ||
PASS e.style['shape-rendering'] = "optimizespeed" should set the property value | ||
PASS e.style['shape-rendering'] = "crispedges" should set the property value | ||
FAIL e.style['shape-rendering'] = "geometricprecision" should set the property value assert_equals: serialization should be canonical expected "geometricprecision" but got "geometricPrecision" | ||
PASS e.style['shape-rendering'] = "geometricprecision" should set the property value | ||
|
6 changes: 3 additions & 3 deletions
6
...imported/w3c/web-platform-tests/svg/painting/parsing/text-rendering-computed-expected.txt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,6 @@ | ||
|
||
PASS Property text-rendering value 'auto' | ||
FAIL Property text-rendering value 'optimizespeed' assert_equals: expected "optimizespeed" but got "optimizeSpeed" | ||
FAIL Property text-rendering value 'optimizelegibility' assert_equals: expected "optimizelegibility" but got "optimizeLegibility" | ||
FAIL Property text-rendering value 'geometricprecision' assert_equals: expected "geometricprecision" but got "geometricPrecision" | ||
PASS Property text-rendering value 'optimizespeed' | ||
PASS Property text-rendering value 'optimizelegibility' | ||
PASS Property text-rendering value 'geometricprecision' | ||
|
6 changes: 3 additions & 3 deletions
6
...ts/imported/w3c/web-platform-tests/svg/painting/parsing/text-rendering-valid-expected.txt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,6 @@ | ||
|
||
PASS e.style['text-rendering'] = "auto" should set the property value | ||
FAIL e.style['text-rendering'] = "optimizespeed" should set the property value assert_equals: serialization should be canonical expected "optimizespeed" but got "optimizeSpeed" | ||
FAIL e.style['text-rendering'] = "optimizelegibility" should set the property value assert_equals: serialization should be canonical expected "optimizelegibility" but got "optimizeLegibility" | ||
FAIL e.style['text-rendering'] = "geometricprecision" should set the property value assert_equals: serialization should be canonical expected "geometricprecision" but got "geometricPrecision" | ||
PASS e.style['text-rendering'] = "optimizespeed" should set the property value | ||
PASS e.style['text-rendering'] = "optimizelegibility" should set the property value | ||
PASS e.style['text-rendering'] = "geometricprecision" should set the property value | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.