-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[PlayStation][wincairo] fix assertion with SingleWebProcess mode
https://bugs.webkit.org/show_bug.cgi?id=263185 Reviewed by Chris Dumez. The WebPageProxy::continueNavigationInNewProcess() function attempts to create a new WebProcess to continue processing a response from a particular websites. If the application sets usesSingleWebProcess = true, the WebPageProxy will attempt to reuse an existing process, but unfortunately there is an assert that is not supposed to do that, so the application with debug build will crash. The NetworkResourceLoader in NetworkProcess decides whether to create a new WebProcess. So this patch makes two changes: 1. add SingleWebProcess flag to NetworkProcessPreferencesForWebProcess 2. use StayInGroup(do not create a new WebProcess) if SingleWebProcess Incidentally, besides some ASSERTs, the connection with the automation target was also not very well considered for SingleWebProcess mode. For example, WebPageProxy::resetStateAfterProcessTermination() calls disconnect() to target, but no one reconnects afterwards. This raises a WebDriver Exception even if it is a release build. This patch will solve this as well. Canonical link: https://commits.webkit.org/278467@main
- Loading branch information
1 parent
79f1358
commit 5d53332
Showing
7 changed files
with
8 additions
and
3 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters