AX: Add logging of time of execution to AXLogger.

https://bugs.webkit.org/show_bug.cgi?id=262992 <rdar://problem/116784445> Reviewed by Tyler Wilcock. Helpful to progile individual method performance. * Source/WebCore/accessibility/AXLogger.cpp: (WebCore::AXLogger::AXLogger): (WebCore::AXLogger::~AXLogger): * Source/WebCore/accessibility/AXLogger.h: Canonical link: https://commits.webkit.org/269198@main
WebKit · Oct 11, 2023 · 5d5857e · 5d5857e
1 parent 765dffe
commit 5d5857e
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 3 deletions.
diff --git a/Source/WebCore/accessibility/AXLogger.cpp b/Source/WebCore/accessibility/AXLogger.cpp
@@ -79,13 +79,18 @@ AXLogger::AXLogger(const String& methodName)
         if (!m_methodName.isEmpty())
             LOG_WITH_STREAM(Accessibility, stream << m_methodName << " {");
     }
+    m_startTime = MonotonicTime::now();
 }
 
 AXLogger::~AXLogger()
 {
-    if (shouldLog()) {
-        if (!m_methodName.isEmpty())
-            LOG_WITH_STREAM(Accessibility, stream << "} " << m_methodName);
+    static const Seconds ExecutionTimeThreshold { 1_s };
+    auto elapsedTime = MonotonicTime::now() - m_startTime;
+    if (shouldLog() && !m_methodName.isEmpty()) {
+        if (elapsedTime > ExecutionTimeThreshold)
+            LOG_WITH_STREAM(Accessibility, stream << "} " << m_methodName << " exceeded ExecutionTimeThreshold " << elapsedTime);
+        else
+            LOG_WITH_STREAM(Accessibility, stream << "} " << m_methodName << " took " << elapsedTime);
     }
 }
 

diff --git a/Source/WebCore/accessibility/AXLogger.h b/Source/WebCore/accessibility/AXLogger.h
@@ -27,6 +27,7 @@
 
 #include "AXCoreObject.h"
 #include "AXObjectCache.h"
+#include <wtf/MonotonicTime.h>
 
 namespace WebCore {
 
@@ -69,6 +70,7 @@ class AXLogger {
 private:
     bool shouldLog();
     String m_methodName;
+    MonotonicTime m_startTime;
 };
 
 #define AXTRACE(methodName) AXLogger axLogger(methodName)