Add assertions to make sure RenderObject type checks stay accurate

https://bugs.webkit.org/show_bug.cgi?id=264319 Reviewed by Simon Fraser. * Source/WebCore/rendering/RenderAttachment.cpp: (WebCore::RenderAttachment::RenderAttachment): * Source/WebCore/rendering/RenderBlock.cpp: (WebCore::RenderBlock::RenderBlock): * Source/WebCore/rendering/RenderBlockFlow.cpp: (WebCore::RenderBlockFlow::RenderBlockFlow): * Source/WebCore/rendering/RenderBox.cpp: (WebCore::RenderBox::RenderBox): * Source/WebCore/rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::RenderBoxModelObject): * Source/WebCore/rendering/RenderButton.cpp: (WebCore::RenderButton::RenderButton): * Source/WebCore/rendering/RenderCombineText.cpp: (WebCore::RenderCombineText::RenderCombineText): * Source/WebCore/rendering/RenderCounter.cpp: (WebCore::RenderCounter::RenderCounter): * Source/WebCore/rendering/RenderDetailsMarker.cpp: (WebCore::RenderDetailsMarker::RenderDetailsMarker): * Source/WebCore/rendering/RenderElement.cpp: (WebCore::RenderElement::RenderElement): * Source/WebCore/rendering/RenderEmbeddedObject.cpp: (WebCore::RenderEmbeddedObject::RenderEmbeddedObject): * Source/WebCore/rendering/RenderFileUploadControl.cpp: (WebCore::RenderFileUploadControl::RenderFileUploadControl): * Source/WebCore/rendering/RenderFlexibleBox.cpp: (WebCore::RenderFlexibleBox::RenderFlexibleBox): * Source/WebCore/rendering/RenderFragmentContainerSet.cpp: (WebCore::RenderFragmentContainerSet::RenderFragmentContainerSet): * Source/WebCore/rendering/RenderFragmentedFlow.cpp: (WebCore::RenderFragmentedFlow::RenderFragmentedFlow): * Source/WebCore/rendering/RenderFrame.cpp: (WebCore::RenderFrame::RenderFrame): * Source/WebCore/rendering/RenderFrameSet.cpp: (WebCore::RenderFrameSet::RenderFrameSet): * Source/WebCore/rendering/RenderGrid.cpp: (WebCore::RenderGrid::RenderGrid): * Source/WebCore/rendering/RenderHTMLCanvas.cpp: (WebCore::RenderHTMLCanvas::RenderHTMLCanvas): * Source/WebCore/rendering/RenderIFrame.cpp: (WebCore::RenderIFrame::RenderIFrame): * Source/WebCore/rendering/RenderInline.cpp: (WebCore::RenderInline::RenderInline): * Source/WebCore/rendering/RenderLayerModelObject.cpp: (WebCore::RenderLayerModelObject::RenderLayerModelObject): * Source/WebCore/rendering/RenderLineBreak.cpp: (WebCore::RenderLineBreak::RenderLineBreak): * Source/WebCore/rendering/RenderListItem.cpp: (WebCore::RenderListItem::RenderListItem): * Source/WebCore/rendering/RenderListMarker.cpp: (WebCore::RenderListMarker::RenderListMarker): * Source/WebCore/rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::RenderMenuList): * Source/WebCore/rendering/RenderMeter.cpp: (WebCore::RenderMeter::RenderMeter): * Source/WebCore/rendering/RenderModel.cpp: * Source/WebCore/rendering/RenderMultiColumnFlow.cpp: (WebCore::RenderMultiColumnFlow::RenderMultiColumnFlow): * Source/WebCore/rendering/RenderMultiColumnSet.cpp: (WebCore::RenderMultiColumnSet::RenderMultiColumnSet): * Source/WebCore/rendering/RenderMultiColumnSpannerPlaceholder.cpp: (WebCore::RenderMultiColumnSpannerPlaceholder::RenderMultiColumnSpannerPlaceholder): * Source/WebCore/rendering/RenderObject.h: (WebCore::RenderObject::isRenderMathMLTable const): * Source/WebCore/rendering/RenderProgress.cpp: (WebCore::RenderProgress::RenderProgress): * Source/WebCore/rendering/RenderQuote.cpp: (WebCore::RenderQuote::RenderQuote): * Source/WebCore/rendering/RenderReplaced.cpp: (WebCore::RenderReplaced::RenderReplaced): * Source/WebCore/rendering/RenderRuby.cpp: (WebCore::RenderRubyAsInline::RenderRubyAsInline): (WebCore::RenderRubyAsBlock::RenderRubyAsBlock): * Source/WebCore/rendering/RenderRubyBase.cpp: (WebCore::RenderRubyBase::RenderRubyBase): * Source/WebCore/rendering/RenderRubyRun.cpp: (WebCore::RenderRubyRun::RenderRubyRun): * Source/WebCore/rendering/RenderRubyText.cpp: (WebCore::RenderRubyText::RenderRubyText): * Source/WebCore/rendering/RenderScrollbarPart.cpp: (WebCore::RenderScrollbarPart::RenderScrollbarPart): * Source/WebCore/rendering/RenderSearchField.cpp: (WebCore::RenderSearchField::RenderSearchField): * Source/WebCore/rendering/RenderSlider.cpp: (WebCore::RenderSlider::RenderSlider): * Source/WebCore/rendering/RenderTable.cpp: (WebCore::RenderTable::RenderTable): * Source/WebCore/rendering/RenderTableCaption.cpp: (WebCore::RenderTableCaption::RenderTableCaption): * Source/WebCore/rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::RenderTableCell): * Source/WebCore/rendering/RenderTableCol.cpp: (WebCore::RenderTableCol::RenderTableCol): * Source/WebCore/rendering/RenderTableRow.cpp: (WebCore::RenderTableRow::RenderTableRow): * Source/WebCore/rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::RenderTableSection): * Source/WebCore/rendering/RenderText.cpp: (WebCore::RenderText::RenderText): * Source/WebCore/rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::RenderTextControl): * Source/WebCore/rendering/RenderTextControlMultiLine.cpp: (WebCore::RenderTextControlMultiLine::RenderTextControlMultiLine): * Source/WebCore/rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlInnerBlock::RenderTextControlInnerBlock): * Source/WebCore/rendering/RenderVTTCue.cpp: (WebCore::RenderVTTCue::RenderVTTCue): * Source/WebCore/rendering/RenderVideo.cpp: (WebCore::RenderVideo::RenderVideo): * Source/WebCore/rendering/RenderView.cpp: (WebCore::RenderView::RenderView): * Source/WebCore/rendering/mathml/RenderMathMLBlockInlines.h: (WebCore::RenderMathMLTable::RenderMathMLTable): * Source/WebCore/rendering/mathml/RenderMathMLFenced.cpp: (WebCore::RenderMathMLFenced::RenderMathMLFenced): * Source/WebCore/rendering/mathml/RenderMathMLFencedOperator.cpp: (WebCore::RenderMathMLFencedOperator::RenderMathMLFencedOperator): * Source/WebCore/rendering/mathml/RenderMathMLFraction.cpp: (WebCore::RenderMathMLFraction::RenderMathMLFraction): * Source/WebCore/rendering/mathml/RenderMathMLMath.cpp: (WebCore::RenderMathMLMath::RenderMathMLMath): * Source/WebCore/rendering/mathml/RenderMathMLMenclose.cpp: (WebCore::RenderMathMLMenclose::RenderMathMLMenclose): * Source/WebCore/rendering/mathml/RenderMathMLPadded.cpp: (WebCore::RenderMathMLPadded::RenderMathMLPadded): * Source/WebCore/rendering/mathml/RenderMathMLRoot.cpp: (WebCore::RenderMathMLRoot::RenderMathMLRoot): * Source/WebCore/rendering/mathml/RenderMathMLRow.cpp: (WebCore::RenderMathMLRow::RenderMathMLRow): * Source/WebCore/rendering/mathml/RenderMathMLSpace.cpp: (WebCore::RenderMathMLSpace::RenderMathMLSpace): * Source/WebCore/rendering/mathml/RenderMathMLUnderOver.cpp: (WebCore::RenderMathMLUnderOver::RenderMathMLUnderOver): * Source/WebCore/rendering/svg/RenderSVGForeignObject.cpp: (WebCore::RenderSVGForeignObject::RenderSVGForeignObject): * Source/WebCore/rendering/svg/RenderSVGGradientStop.cpp: (WebCore::RenderSVGGradientStop::RenderSVGGradientStop): * Source/WebCore/rendering/svg/RenderSVGHiddenContainer.cpp: (WebCore::RenderSVGHiddenContainer::RenderSVGHiddenContainer): * Source/WebCore/rendering/svg/RenderSVGImage.cpp: (WebCore::RenderSVGImage::RenderSVGImage): * Source/WebCore/rendering/svg/RenderSVGInline.cpp: (WebCore::RenderSVGInline::RenderSVGInline): * Source/WebCore/rendering/svg/RenderSVGInlineText.cpp: (WebCore::RenderSVGInlineText::RenderSVGInlineText): * Source/WebCore/rendering/svg/RenderSVGPath.cpp: (WebCore::RenderSVGPath::RenderSVGPath): * Source/WebCore/rendering/svg/RenderSVGResourceClipper.cpp: (WebCore::RenderSVGResourceClipper::RenderSVGResourceClipper): * Source/WebCore/rendering/svg/RenderSVGResourceContainer.cpp: (WebCore::RenderSVGResourceContainer::RenderSVGResourceContainer): * Source/WebCore/rendering/svg/RenderSVGRoot.cpp: (WebCore::RenderSVGRoot::RenderSVGRoot): * Source/WebCore/rendering/svg/RenderSVGTSpan.h: * Source/WebCore/rendering/svg/RenderSVGText.cpp: (WebCore::RenderSVGText::RenderSVGText): * Source/WebCore/rendering/svg/RenderSVGTextPath.cpp: (WebCore::RenderSVGTextPath::RenderSVGTextPath): * Source/WebCore/rendering/svg/RenderSVGTransformableContainer.cpp: (WebCore::RenderSVGTransformableContainer::RenderSVGTransformableContainer): * Source/WebCore/rendering/svg/RenderSVGViewportContainer.cpp: (WebCore::RenderSVGViewportContainer::RenderSVGViewportContainer): * Source/WebCore/rendering/svg/legacy/LegacyRenderSVGForeignObject.cpp: (WebCore::LegacyRenderSVGForeignObject::LegacyRenderSVGForeignObject): * Source/WebCore/rendering/svg/legacy/LegacyRenderSVGImage.cpp: (WebCore::LegacyRenderSVGImage::LegacyRenderSVGImage): * Source/WebCore/rendering/svg/legacy/LegacyRenderSVGPath.cpp: (WebCore::LegacyRenderSVGPath::LegacyRenderSVGPath): * Source/WebCore/rendering/svg/legacy/LegacyRenderSVGRoot.cpp: (WebCore::LegacyRenderSVGRoot::LegacyRenderSVGRoot): * Source/WebCore/rendering/svg/legacy/LegacyRenderSVGTransformableContainer.cpp: (WebCore::LegacyRenderSVGTransformableContainer::LegacyRenderSVGTransformableContainer): * Source/WebCore/rendering/svg/legacy/LegacyRenderSVGViewportContainer.cpp: (WebCore::LegacyRenderSVGViewportContainer::LegacyRenderSVGViewportContainer): Canonical link: https://commits.webkit.org/270353@main
WebKit · Nov 7, 2023 · 5f6e096 · 5f6e096
1 parent 550f36d
commit 5f6e096
Show file tree

Hide file tree

Showing 87 changed files with 104 additions and 2 deletions.
diff --git a/Source/WebCore/rendering/RenderAttachment.cpp b/Source/WebCore/rendering/RenderAttachment.cpp
@@ -49,6 +49,7 @@ RenderAttachment::RenderAttachment(HTMLAttachmentElement& element, RenderStyle&&
     : RenderReplaced(Type::Attachment, element, WTFMove(style), LayoutSize())
     , m_isWideLayout(element.isWideLayout())
 {
+    ASSERT(isAttachment());
 #if ENABLE(SERVICE_CONTROLS)
     m_hasShadowControls = element.isImageMenuEnabled();
 #endif

diff --git a/Source/WebCore/rendering/RenderBlock.cpp b/Source/WebCore/rendering/RenderBlock.cpp
@@ -307,11 +307,13 @@ class OverflowEventDispatcher {
 RenderBlock::RenderBlock(Type type, Element& element, RenderStyle&& style, BaseTypeFlags baseTypeFlags)
     : RenderBox(type, element, WTFMove(style), baseTypeFlags | RenderBlockFlag)
 {
+    ASSERT(isRenderBlock());
 }
 
 RenderBlock::RenderBlock(Type type, Document& document, RenderStyle&& style, BaseTypeFlags baseTypeFlags)
     : RenderBox(type, document, WTFMove(style), baseTypeFlags | RenderBlockFlag)
 {
+    ASSERT(isRenderBlock());
 }
 
 static void removeBlockFromPercentageDescendantAndContainerMaps(RenderBlock& block)

diff --git a/Source/WebCore/rendering/RenderBlockFlow.cpp b/Source/WebCore/rendering/RenderBlockFlow.cpp
@@ -122,6 +122,7 @@ RenderBlockFlow::RenderBlockFlow(Type type, Element& element, RenderStyle&& styl
     , m_lineCountForTextAutosizing(NOT_SET)
 #endif
 {
+    ASSERT(isRenderBlockFlow());
     setChildrenInline(true);
 }
 
@@ -132,6 +133,7 @@ RenderBlockFlow::RenderBlockFlow(Type type, Document& document, RenderStyle&& st
     , m_lineCountForTextAutosizing(NOT_SET)
 #endif
 {
+    ASSERT(isRenderBlockFlow());
     setChildrenInline(true);
 }
 

diff --git a/Source/WebCore/rendering/RenderBox.cpp b/Source/WebCore/rendering/RenderBox.cpp
@@ -156,12 +156,14 @@ RenderBox::RenderBox(Type type, Element& element, RenderStyle&& style, BaseTypeF
     : RenderBoxModelObject(type, element, WTFMove(style), baseTypeFlags)
 {
     setIsBox();
+    ASSERT(isBox());
 }
 
 RenderBox::RenderBox(Type type, Document& document, RenderStyle&& style, BaseTypeFlags baseTypeFlags)
     : RenderBoxModelObject(type, document, WTFMove(style), baseTypeFlags)
 {
     setIsBox();
+    ASSERT(isBox());
 }
 
 RenderBox::~RenderBox()

diff --git a/Source/WebCore/rendering/RenderBoxModelObject.cpp b/Source/WebCore/rendering/RenderBoxModelObject.cpp
@@ -170,11 +170,13 @@ bool RenderBoxModelObject::hasAcceleratedCompositing() const
 RenderBoxModelObject::RenderBoxModelObject(Type type, Element& element, RenderStyle&& style, BaseTypeFlags baseTypeFlags)
     : RenderLayerModelObject(type, element, WTFMove(style), baseTypeFlags | RenderBoxModelObjectFlag)
 {
+    ASSERT(isBoxModelObject());
 }
 
 RenderBoxModelObject::RenderBoxModelObject(Type type, Document& document, RenderStyle&& style, BaseTypeFlags baseTypeFlags)
     : RenderLayerModelObject(type, document, WTFMove(style), baseTypeFlags | RenderBoxModelObjectFlag)
 {
+    ASSERT(isBoxModelObject());
 }
 
 RenderBoxModelObject::~RenderBoxModelObject()

diff --git a/Source/WebCore/rendering/RenderButton.cpp b/Source/WebCore/rendering/RenderButton.cpp
@@ -48,6 +48,7 @@ WTF_MAKE_ISO_ALLOCATED_IMPL(RenderButton);
 RenderButton::RenderButton(HTMLFormControlElement& element, RenderStyle&& style)
     : RenderFlexibleBox(Type::Button, element, WTFMove(style))
 {
+    ASSERT(isRenderButton());
 }
 
 RenderButton::~RenderButton() = default;

diff --git a/Source/WebCore/rendering/RenderCombineText.cpp b/Source/WebCore/rendering/RenderCombineText.cpp
@@ -38,6 +38,7 @@ RenderCombineText::RenderCombineText(Text& textNode, const String& string)
     , m_isCombined(false)
     , m_needsFontUpdate(false)
 {
+    ASSERT(isCombineText());
 }
 
 void RenderCombineText::styleDidChange(StyleDifference diff, const RenderStyle* oldStyle)

diff --git a/Source/WebCore/rendering/RenderCounter.cpp b/Source/WebCore/rendering/RenderCounter.cpp
@@ -435,6 +435,7 @@ RenderCounter::RenderCounter(Document& document, const CounterContent& counter)
     : RenderText(Type::Counter, document, emptyString())
     , m_counter(counter)
 {
+    ASSERT(isCounter());
     view().addCounterNeedingUpdate(*this);
 }
 

diff --git a/Source/WebCore/rendering/RenderDetailsMarker.cpp b/Source/WebCore/rendering/RenderDetailsMarker.cpp
@@ -40,6 +40,7 @@ WTF_MAKE_ISO_ALLOCATED_IMPL(RenderDetailsMarker);
 RenderDetailsMarker::RenderDetailsMarker(DetailsMarkerControl& element, RenderStyle&& style)
     : RenderBlockFlow(Type::DetailsMarker, element, WTFMove(style))
 {
+    ASSERT(isDetailsMarker());
 }
 
 static Path createPath(const FloatPoint* path)

diff --git a/Source/WebCore/rendering/RenderElement.cpp b/Source/WebCore/rendering/RenderElement.cpp
@@ -137,6 +137,7 @@ inline RenderElement::RenderElement(Type type, ContainerNode& elementOrDocument,
     , m_didContributeToVisuallyNonEmptyPixelCount(false)
     , m_style(WTFMove(style))
 {
+    ASSERT(RenderObject::isRenderElement());
 }
 
 RenderElement::RenderElement(Type type, Element& element, RenderStyle&& style, BaseTypeFlags baseTypeFlags)

diff --git a/Source/WebCore/rendering/RenderEmbeddedObject.cpp b/Source/WebCore/rendering/RenderEmbeddedObject.cpp
@@ -86,6 +86,7 @@ RenderEmbeddedObject::RenderEmbeddedObject(HTMLFrameOwnerElement& element, Rende
     , m_unavailablePluginIndicatorIsPressed(false)
     , m_mouseDownWasInUnavailablePluginIndicator(false)
 {
+    ASSERT(isEmbeddedObject());
 }
 
 RenderEmbeddedObject::~RenderEmbeddedObject()

diff --git a/Source/WebCore/rendering/RenderFileUploadControl.cpp b/Source/WebCore/rendering/RenderFileUploadControl.cpp
@@ -72,6 +72,7 @@ RenderFileUploadControl::RenderFileUploadControl(HTMLInputElement& input, Render
     : RenderBlockFlow(Type::FileUploadControl, input, WTFMove(style))
     , m_canReceiveDroppedFiles(input.canReceiveDroppedFiles())
 {
+    ASSERT(isFileUploadControl());
 }
 
 RenderFileUploadControl::~RenderFileUploadControl() = default;

diff --git a/Source/WebCore/rendering/RenderFlexibleBox.cpp b/Source/WebCore/rendering/RenderFlexibleBox.cpp
@@ -83,12 +83,14 @@ struct RenderFlexibleBox::LineState {
 RenderFlexibleBox::RenderFlexibleBox(Type type, Element& element, RenderStyle&& style)
     : RenderBlock(type, element, WTFMove(style), RenderFlexibleBoxFlag)
 {
+    ASSERT(isRenderFlexibleBox());
     setChildrenInline(false); // All of our children must be block-level.
 }
 
 RenderFlexibleBox::RenderFlexibleBox(Type type, Document& document, RenderStyle&& style)
     : RenderBlock(type, document, WTFMove(style), RenderFlexibleBoxFlag)
 {
+    ASSERT(isRenderFlexibleBox());
     setChildrenInline(false); // All of our children must be block-level.
 }
 

diff --git a/Source/WebCore/rendering/RenderFragmentContainerSet.cpp b/Source/WebCore/rendering/RenderFragmentContainerSet.cpp
@@ -38,6 +38,7 @@ WTF_MAKE_ISO_ALLOCATED_IMPL(RenderFragmentContainerSet);
 RenderFragmentContainerSet::RenderFragmentContainerSet(Type type, Document& document, RenderStyle&& style, RenderFragmentedFlow& fragmentedFlow)
     : RenderFragmentContainer(type, document, WTFMove(style), &fragmentedFlow)
 {
+    ASSERT(is<RenderFragmentContainerSet>(*this));
 }
 
 void RenderFragmentContainerSet::installFragmentedFlow()

diff --git a/Source/WebCore/rendering/RenderFragmentedFlow.cpp b/Source/WebCore/rendering/RenderFragmentedFlow.cpp
@@ -64,6 +64,7 @@ RenderFragmentedFlow::RenderFragmentedFlow(Type type, Document& document, Render
     , m_pageLogicalSizeChanged(false)
 {
     setIsRenderFragmentedFlow(true);
+    ASSERT(isRenderFragmentedFlow());
 }
 
 void RenderFragmentedFlow::styleDidChange(StyleDifference diff, const RenderStyle* oldStyle)

diff --git a/Source/WebCore/rendering/RenderFrame.cpp b/Source/WebCore/rendering/RenderFrame.cpp
@@ -37,6 +37,7 @@ WTF_MAKE_ISO_ALLOCATED_IMPL(RenderFrame);
 RenderFrame::RenderFrame(HTMLFrameElement& frame, RenderStyle&& style)
     : RenderFrameBase(Type::Frame, frame, WTFMove(style))
 {
+    ASSERT(isFrame());
 }
 
 HTMLFrameElement& RenderFrame::frameElement() const

diff --git a/Source/WebCore/rendering/RenderFrameSet.cpp b/Source/WebCore/rendering/RenderFrameSet.cpp
@@ -58,6 +58,7 @@ RenderFrameSet::RenderFrameSet(HTMLFrameSetElement& frameSet, RenderStyle&& styl
     : RenderBox(Type::FrameSet, frameSet, WTFMove(style), 0)
     , m_isResizing(false)
 {
+    ASSERT(isFrameSet());
     setInline(false);
 }
 

diff --git a/Source/WebCore/rendering/RenderGrid.cpp b/Source/WebCore/rendering/RenderGrid.cpp
@@ -56,6 +56,7 @@ RenderGrid::RenderGrid(Element& element, RenderStyle&& style)
     , m_trackSizingAlgorithm(this, currentGrid())
     , m_masonryLayout(*this)
 {
+    ASSERT(isRenderGrid());
     // All of our children must be block level.
     setChildrenInline(false);
 }

diff --git a/Source/WebCore/rendering/RenderHTMLCanvas.cpp b/Source/WebCore/rendering/RenderHTMLCanvas.cpp
@@ -52,6 +52,7 @@ WTF_MAKE_ISO_ALLOCATED_IMPL(RenderHTMLCanvas);
 RenderHTMLCanvas::RenderHTMLCanvas(HTMLCanvasElement& element, RenderStyle&& style)
     : RenderReplaced(Type::HTMLCanvas, element, WTFMove(style), element.size())
 {
+    ASSERT(isCanvas());
 }
 
 HTMLCanvasElement& RenderHTMLCanvas::canvasElement() const

diff --git a/Source/WebCore/rendering/RenderIFrame.cpp b/Source/WebCore/rendering/RenderIFrame.cpp
@@ -47,6 +47,7 @@ using namespace HTMLNames;
 RenderIFrame::RenderIFrame(HTMLIFrameElement& element, RenderStyle&& style)
     : RenderFrameBase(Type::IFrame, element, WTFMove(style))
 {
+    ASSERT(isRenderIFrame());
 }
 
 HTMLIFrameElement& RenderIFrame::iframeElement() const

diff --git a/Source/WebCore/rendering/RenderInline.cpp b/Source/WebCore/rendering/RenderInline.cpp
@@ -68,12 +68,14 @@ RenderInline::RenderInline(Type type, Element& element, RenderStyle&& style)
     : RenderBoxModelObject(type, element, WTFMove(style), RenderInlineFlag)
 {
     setChildrenInline(true);
+    ASSERT(isRenderInline());
 }
 
 RenderInline::RenderInline(Type type, Document& document, RenderStyle&& style)
     : RenderBoxModelObject(type, document, WTFMove(style), RenderInlineFlag)
 {
     setChildrenInline(true);
+    ASSERT(isRenderInline());
 }
 
 void RenderInline::willBeDestroyed()

diff --git a/Source/WebCore/rendering/RenderLayerModelObject.cpp b/Source/WebCore/rendering/RenderLayerModelObject.cpp
@@ -60,11 +60,13 @@ bool RenderLayerModelObject::s_layerWasSelfPainting = false;
 RenderLayerModelObject::RenderLayerModelObject(Type type, Element& element, RenderStyle&& style, BaseTypeFlags baseTypeFlags)
     : RenderElement(type, element, WTFMove(style), baseTypeFlags | RenderLayerModelObjectFlag)
 {
+    ASSERT(isRenderLayerModelObject());
 }
 
 RenderLayerModelObject::RenderLayerModelObject(Type type, Document& document, RenderStyle&& style, BaseTypeFlags baseTypeFlags)
     : RenderElement(type, document, WTFMove(style), baseTypeFlags | RenderLayerModelObjectFlag)
 {
+    ASSERT(isRenderLayerModelObject());
 }
 
 RenderLayerModelObject::~RenderLayerModelObject()

diff --git a/Source/WebCore/rendering/RenderLineBreak.cpp b/Source/WebCore/rendering/RenderLineBreak.cpp
@@ -55,6 +55,7 @@ RenderLineBreak::RenderLineBreak(HTMLElement& element, RenderStyle&& style)
     , m_cachedLineHeight(invalidLineHeight)
     , m_isWBR(is<HTMLWBRElement>(element))
 {
+    ASSERT(isLineBreak());
 }
 
 RenderLineBreak::~RenderLineBreak()

diff --git a/Source/WebCore/rendering/RenderListItem.cpp b/Source/WebCore/rendering/RenderListItem.cpp
@@ -52,6 +52,7 @@ WTF_MAKE_ISO_ALLOCATED_IMPL(RenderListItem);
 RenderListItem::RenderListItem(Element& element, RenderStyle&& style)
     : RenderBlockFlow(Type::ListItem, element, WTFMove(style))
 {
+    ASSERT(isListItem());
     setInline(false);
 }
 

diff --git a/Source/WebCore/rendering/RenderListMarker.cpp b/Source/WebCore/rendering/RenderListMarker.cpp
@@ -55,6 +55,7 @@ RenderListMarker::RenderListMarker(RenderListItem& listItem, RenderStyle&& style
 {
     setInline(true);
     setReplacedOrInlineBlock(true); // pretend to be replaced
+    ASSERT(isListMarker());
 }
 
 RenderListMarker::~RenderListMarker()

diff --git a/Source/WebCore/rendering/RenderMenuList.cpp b/Source/WebCore/rendering/RenderMenuList.cpp
@@ -89,6 +89,7 @@ RenderMenuList::RenderMenuList(HTMLSelectElement& element, RenderStyle&& style)
     , m_popupIsVisible(false)
 #endif
 {
+    ASSERT(isMenuList());
 }
 
 RenderMenuList::~RenderMenuList()

diff --git a/Source/WebCore/rendering/RenderMeter.cpp b/Source/WebCore/rendering/RenderMeter.cpp
@@ -37,6 +37,7 @@ WTF_MAKE_ISO_ALLOCATED_IMPL(RenderMeter);
 RenderMeter::RenderMeter(HTMLElement& element, RenderStyle&& style)
     : RenderBlockFlow(Type::Meter, element, WTFMove(style))
 {
+    ASSERT(isMeter());
 }
 
 RenderMeter::~RenderMeter() = default;

diff --git a/Source/WebCore/rendering/RenderModel.cpp b/Source/WebCore/rendering/RenderModel.cpp
@@ -39,6 +39,7 @@ WTF_MAKE_ISO_ALLOCATED_IMPL(RenderModel);
 RenderModel::RenderModel(HTMLModelElement& element, RenderStyle&& style)
     : RenderReplaced { Type::Model, element, WTFMove(style) }
 {
+    ASSERT(isRenderModel());
 }
 
 // Do not add any code to the destructor, instead, add it to willBeDestroyed().

diff --git a/Source/WebCore/rendering/RenderMultiColumnFlow.cpp b/Source/WebCore/rendering/RenderMultiColumnFlow.cpp
@@ -49,6 +49,7 @@ RenderMultiColumnFlow::RenderMultiColumnFlow(Document& document, RenderStyle&& s
     , m_spannerMap(makeUnique<SpannerMap>())
 {
     setFragmentedFlowState(InsideInFragmentedFlow);
+    ASSERT(isRenderMultiColumnFlow());
 }
 
 RenderMultiColumnFlow::~RenderMultiColumnFlow() = default;

diff --git a/Source/WebCore/rendering/RenderMultiColumnSet.cpp b/Source/WebCore/rendering/RenderMultiColumnSet.cpp
@@ -49,6 +49,7 @@ RenderMultiColumnSet::RenderMultiColumnSet(RenderFragmentedFlow& fragmentedFlow,
     , m_maxColumnHeight(RenderFragmentedFlow::maxLogicalHeight())
     , m_minSpaceShortage(RenderFragmentedFlow::maxLogicalHeight())
 {
+    ASSERT(isRenderMultiColumnSet());
 }
 
 RenderMultiColumnSet* RenderMultiColumnSet::nextSiblingMultiColumnSet() const

diff --git a/Source/WebCore/rendering/RenderMultiColumnSpannerPlaceholder.cpp b/Source/WebCore/rendering/RenderMultiColumnSpannerPlaceholder.cpp
@@ -53,6 +53,7 @@ RenderMultiColumnSpannerPlaceholder::RenderMultiColumnSpannerPlaceholder(RenderM
     , m_spanner(spanner)
     , m_fragmentedFlow(fragmentedFlow)
 {
+    ASSERT(isRenderMultiColumnSpannerPlaceholder());
 }
 
 ASCIILiteral RenderMultiColumnSpannerPlaceholder::renderName() const

diff --git a/Source/WebCore/rendering/RenderObject.h b/Source/WebCore/rendering/RenderObject.h
@@ -422,7 +422,7 @@ class RenderObject : public CachedImageClient, public CanMakeCheckedPtr {
 
 #if ENABLE(MATHML)
     virtual bool isRenderMathMLBlock() const { return false; }
-    virtual bool isRenderMathMLTable() const { return type() == Type::MathMLTable; }
+    bool isRenderMathMLTable() const { return type() == Type::MathMLTable; }
     virtual bool isRenderMathMLOperator() const { return false; }
     bool isRenderMathMLRow() const;
     bool isRenderMathMLMath() const { return type() == Type::MathMLMath; }

diff --git a/Source/WebCore/rendering/RenderProgress.cpp b/Source/WebCore/rendering/RenderProgress.cpp
@@ -37,6 +37,7 @@ RenderProgress::RenderProgress(HTMLElement& element, RenderStyle&& style)
     , m_position(HTMLProgressElement::InvalidPosition)
     , m_animationTimer(*this, &RenderProgress::animationTimerFired)
 {
+    ASSERT(isProgress());
 }
 
 RenderProgress::~RenderProgress() = default;

diff --git a/Source/WebCore/rendering/RenderQuote.cpp b/Source/WebCore/rendering/RenderQuote.cpp
@@ -41,6 +41,7 @@ RenderQuote::RenderQuote(Document& document, RenderStyle&& style, QuoteType quot
     , m_type(quote)
     , m_text(emptyString())
 {
+    ASSERT(isQuote());
 }
 
 RenderQuote::~RenderQuote()

diff --git a/Source/WebCore/rendering/RenderReplaced.cpp b/Source/WebCore/rendering/RenderReplaced.cpp
@@ -70,20 +70,23 @@ RenderReplaced::RenderReplaced(Type type, Element& element, RenderStyle&& style)
     , m_intrinsicSize(cDefaultWidth, cDefaultHeight)
 {
     setReplacedOrInlineBlock(true);
+    ASSERT(isRenderReplaced());
 }
 
 RenderReplaced::RenderReplaced(Type type, Element& element, RenderStyle&& style, const LayoutSize& intrinsicSize)
     : RenderBox(type, element, WTFMove(style), RenderReplacedFlag)
     , m_intrinsicSize(intrinsicSize)
 {
     setReplacedOrInlineBlock(true);
+    ASSERT(isRenderReplaced());
 }
 
 RenderReplaced::RenderReplaced(Type type, Document& document, RenderStyle&& style, const LayoutSize& intrinsicSize)
     : RenderBox(type, document, WTFMove(style), RenderReplacedFlag)
     , m_intrinsicSize(intrinsicSize)
 {
     setReplacedOrInlineBlock(true);
+    ASSERT(isRenderReplaced());
 }
 
 RenderReplaced::~RenderReplaced() = default;

diff --git a/Source/WebCore/rendering/RenderRuby.cpp b/Source/WebCore/rendering/RenderRuby.cpp
@@ -51,6 +51,7 @@ WTF_MAKE_ISO_ALLOCATED_IMPL(RenderRubyAsBlock);
 RenderRubyAsInline::RenderRubyAsInline(Element& element, RenderStyle&& style)
     : RenderInline(Type::RubyAsInline, element, WTFMove(style))
 {
+    ASSERT(isRubyInline());
 }
 
 RenderRubyAsInline::~RenderRubyAsInline() = default;
@@ -66,6 +67,7 @@ void RenderRubyAsInline::styleDidChange(StyleDifference diff, const RenderStyle*
 RenderRubyAsBlock::RenderRubyAsBlock(Element& element, RenderStyle&& style)
     : RenderBlockFlow(Type::RubyAsBlock, element, WTFMove(style))
 {
+    ASSERT(isRubyBlock());
 }
 
 RenderRubyAsBlock::~RenderRubyAsBlock() = default;

diff --git a/Source/WebCore/rendering/RenderRubyBase.cpp b/Source/WebCore/rendering/RenderRubyBase.cpp
@@ -49,6 +49,7 @@ RenderRubyBase::RenderRubyBase(Document& document, RenderStyle&& style)
     , m_isAfterExpansion(true)
 {
     setInline(false);
+    ASSERT(isRubyBase());
 }
 
 RenderRubyBase::~RenderRubyBase() = default;

diff --git a/Source/WebCore/rendering/RenderRubyRun.cpp b/Source/WebCore/rendering/RenderRubyRun.cpp
@@ -56,6 +56,7 @@ RenderRubyRun::RenderRubyRun(Document& document, RenderStyle&& style)
 {
     setReplacedOrInlineBlock(true);
     setInline(true);
+    ASSERT(isRubyRun());
 }
 
 RenderRubyRun::~RenderRubyRun() = default;

diff --git a/Source/WebCore/rendering/RenderRubyText.cpp b/Source/WebCore/rendering/RenderRubyText.cpp
@@ -44,6 +44,7 @@ WTF_MAKE_ISO_ALLOCATED_IMPL(RenderRubyText);
 RenderRubyText::RenderRubyText(Element& element, RenderStyle&& style)
     : RenderBlockFlow(Type::RubyText, element, WTFMove(style))
 {
+    ASSERT(isRubyText());
 }
 
 RenderRubyText::~RenderRubyText() = default;

diff --git a/Source/WebCore/rendering/RenderScrollbarPart.cpp b/Source/WebCore/rendering/RenderScrollbarPart.cpp
@@ -45,6 +45,7 @@ RenderScrollbarPart::RenderScrollbarPart(Document& document, RenderStyle&& style
     , m_scrollbar(scrollbar)
     , m_part(part)
 {
+    ASSERT(isRenderScrollbarPart());
 }
 
 RenderScrollbarPart::~RenderScrollbarPart() = default;

diff --git a/Source/WebCore/rendering/RenderSearchField.cpp b/Source/WebCore/rendering/RenderSearchField.cpp
@@ -61,6 +61,7 @@ RenderSearchField::RenderSearchField(HTMLInputElement& element, RenderStyle&& st
     , m_searchPopup(nullptr)
 {
     ASSERT(element.isSearchField());
+    ASSERT(isSearchField());
 }
 
 RenderSearchField::~RenderSearchField()