Skip to content

Commit

Permalink
[css-grid] Update test expectations for css-grid/subgrid/orthogonal-w…
Browse files Browse the repository at this point in the history 
…riting-mode-005.

https://bugs.webkit.org/show_bug.cgi?id=262912
rdar://116685783

Reviewed by Tim Nguyen.

There was a CSSWG discussion regarding some of the subtests within
this test: w3c/csswg-drafts#9418

Based off of the discussion, the subtests should be updated to reflect
the current WebKit rendering.

* LayoutTests/TestExpectations:
* LayoutTests/imported/w3c/web-platform-tests/css/css-grid/subgrid/orthogonal-writing-mode-005-expected.html:
* LayoutTests/imported/w3c/web-platform-tests/css/css-grid/subgrid/orthogonal-writing-mode-005-ref.html:

Canonical link: https://commits.webkit.org/269141@main
  • Loading branch information
@sammygill
sammygill committed Oct 10, 2023
1 parent 405e0bb commit 6126b9b
Show file tree
Hide file tree
Showing 3 changed files with 34 additions and 35 deletions.
1 change: 0 additions & 1 deletion LayoutTests/TestExpectations
View file
Original file line number Diff line number Diff line change
Expand Up @@ -1604,7 +1604,6 @@ imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/subgrid/masonry-c
imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/item-placement/masonry-columns-item-placement-auto-flow-next-001.html [ Skip ]

# Subgrid failures
imported/w3c/web-platform-tests/css/css-grid/subgrid/orthogonal-writing-mode-005.html [ ImageOnlyFailure ]
imported/w3c/web-platform-tests/css/css-grid/subgrid/subgrid-no-items-on-edges-002.html [ ImageOnlyFailure ]

# Timeout
Expand Down
34 changes: 17 additions & 17 deletions ...ted/w3c/web-platform-tests/css/css-grid/subgrid/orthogonal-writing-mode-005-expected.html
View file
Original file line number Diff line number Diff line change
Expand Up @@ -250,37 +250,37 @@
<!-- Named grid areas -->
<div class="grid"><div class="subgrid areas-1a"><div class="subgrid">
<div style="grid-row:1"></div>
<div style="grid-row:1"></div>
<div style="grid-row:1"></div>
<div style="grid-row:2"></div>
<div style="grid-row:1 / -1"></div>
<div style="grid-row:1 / -1"></div>
<div style="grid-row:-1"></div>
</div></div></div>

<div class="grid"><div class="subgrid areas-1b"><div class="subgrid">
<div style="grid-row:1"></div>
<div style="grid-row:1"></div>
<div style="grid-row:1"></div>
<div style="grid-row:2"></div>
<div style="grid-row:2 / -1"></div>
<div style="grid-row:2 / -1"></div>
<div style="grid-row:-1"></div>
</div></div></div>

<div class="grid"><div class="subgrid areas-1c"><div class="subgrid">
<div style="grid-row:1"></div>
<div style="grid-row:1"></div>
<div style="grid-row:1"></div>
<div style="grid-row:2"></div>
<div style="grid-row:1/-2"></div>
<div style="grid-row:1/-2"></div>
<div style="grid-row:-2"></div>
</div></div></div>

<div class="grid"><div class="subgrid areas-1d"><div class="subgrid">
<div style="grid-row:1"></div>
<div style="grid-row:1"></div>
<div style="grid-row:1"></div>
<div style="grid-row:2"></div>
<div style="grid-row:3"></div>
<div style="grid-row:3 / -1"></div>
<div style="grid-row:3 / -1"></div>
<div style="grid-row:-1"></div>
</div></div></div>

<div class="grid"><div class="subgrid areas-1e"><div class="subgrid">
<div style="grid-row:1"></div>
<div style="grid-row:1"></div>
<div style="grid-row:1"></div>
<div style="grid-row:2"></div>
<div style="grid-row:3"></div>
<div style="grid-row:3"></div>
<div style="grid-row:3"></div>
<div style="grid-row:-1"></div>
</div></div></div>
</body>
</html>
34 changes: 17 additions & 17 deletions ...imported/w3c/web-platform-tests/css/css-grid/subgrid/orthogonal-writing-mode-005-ref.html
View file
Original file line number Diff line number Diff line change
Expand Up @@ -250,37 +250,37 @@
<!-- Named grid areas -->
<div class="grid"><div class="subgrid areas-1a"><div class="subgrid">
<div style="grid-row:1"></div>
<div style="grid-row:1"></div>
<div style="grid-row:1"></div>
<div style="grid-row:2"></div>
<div style="grid-row:1 / -1"></div>
<div style="grid-row:1 / -1"></div>
<div style="grid-row:-1"></div>
</div></div></div>

<div class="grid"><div class="subgrid areas-1b"><div class="subgrid">
<div style="grid-row:1"></div>
<div style="grid-row:1"></div>
<div style="grid-row:1"></div>
<div style="grid-row:2"></div>
<div style="grid-row:2 / -1"></div>
<div style="grid-row:2 / -1"></div>
<div style="grid-row:-1"></div>
</div></div></div>

<div class="grid"><div class="subgrid areas-1c"><div class="subgrid">
<div style="grid-row:1"></div>
<div style="grid-row:1"></div>
<div style="grid-row:1"></div>
<div style="grid-row:2"></div>
<div style="grid-row:1/-2"></div>
<div style="grid-row:1/-2"></div>
<div style="grid-row:-2"></div>
</div></div></div>

<div class="grid"><div class="subgrid areas-1d"><div class="subgrid">
<div style="grid-row:1"></div>
<div style="grid-row:1"></div>
<div style="grid-row:1"></div>
<div style="grid-row:2"></div>
<div style="grid-row:3"></div>
<div style="grid-row:3 / -1"></div>
<div style="grid-row:3 / -1"></div>
<div style="grid-row:-1"></div>
</div></div></div>

<div class="grid"><div class="subgrid areas-1e"><div class="subgrid">
<div style="grid-row:1"></div>
<div style="grid-row:1"></div>
<div style="grid-row:1"></div>
<div style="grid-row:2"></div>
<div style="grid-row:3"></div>
<div style="grid-row:3"></div>
<div style="grid-row:3"></div>
<div style="grid-row:-1"></div>
</div></div></div>
</body>
</html>

0 comments on commit 6126b9b

Please sign in to comment.