Skip to content

Commit

Permalink
Cherry-pick 272778@main (4792e09). https://bugs.webkit.org/show_bug.c…
Browse files Browse the repository at this point in the history
…gi?id=132262

    [GLIB] http/tests/media/video-redirect.html is flaky timing out and crashing on Wayland
    https://bugs.webkit.org/show_bug.cgi?id=132262

    Reviewed by Xabier Rodriguez-Calvar.

    Address the crash, EmptyOriginAccessPatterns::singleton() expects a non-WebProcess, which is not the
    case, so use originAccessPatternsForWebProcessOrEmpty() which is more appropriate.

    * LayoutTests/platform/glib/TestExpectations:
    * Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
    (WebCore::MediaPlayerPrivateGStreamer::loadNextLocation):

    Canonical link: https://commits.webkit.org/272778@main
  • Loading branch information
philn authored and aperezdc committed Jan 28, 2024
1 parent a1796de commit 6386848
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion LayoutTests/platform/glib/TestExpectations
Original file line number Diff line number Diff line change
Expand Up @@ -1003,7 +1003,7 @@ webkit.org/b/177294 fast/text/fitzpatrick-combination.html [ ImageOnlyFailure ]
# GStreamer-related bugs
#////////////////////////////////////////////////////////////////////////////////////////

webkit.org/b/132262 http/tests/media/video-redirect.html [ Crash Timeout Pass ]
webkit.org/b/132262 http/tests/media/video-redirect.html [ Timeout Pass ]

webkit.org/b/254520 media/video-ended-event-negative-playback.html [ Failure Timeout Pass ]
webkit.org/b/254519 media/media-continues-playing-after-replace-source.html [ Failure Pass ]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2680,7 +2680,7 @@ bool MediaPlayerPrivateGStreamer::loadNextLocation()

changePipelineState(GST_STATE_READY);
auto securityOrigin = SecurityOrigin::create(m_url);
if (securityOrigin->canRequest(newUrl, EmptyOriginAccessPatterns::singleton())) {
if (securityOrigin->canRequest(newUrl, originAccessPatternsForWebProcessOrEmpty())) {
GST_INFO_OBJECT(pipeline(), "New media url: %s", newUrl.string().utf8().data());

auto player = m_player.get();
Expand Down

0 comments on commit 6386848

Please sign in to comment.