Skip to content

Commit

Permalink
REGRESSION(268320@main): WebDriver fullscreen/input type=file tests f…
Browse files Browse the repository at this point in the history
…ailing

https://bugs.webkit.org/show_bug.cgi?id=263887
rdar://117683701

Reviewed by Tim Nguyen.

Partially revert 268320@main (maintaining the exported WPT test changes,
but reverting all actual source changes) to return to the prior
behaviour of treating all automation protocol scripts as invoked via a
user gesture, fixing the regression but re-introducing the WebDriver
spec violation.

* Source/WebKit/WebProcess/Automation/WebAutomationSessionProxy.cpp:
(WebKit::WebAutomationSessionProxy::evaluateJavaScriptFunction):

Canonical link: https://commits.webkit.org/270201@main
  • Loading branch information
gsnedders committed Nov 3, 2023
1 parent a0c8daa commit 6444dd0
Showing 1 changed file with 4 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -421,7 +421,10 @@ void WebAutomationSessionProxy::evaluateJavaScriptFunction(WebCore::PageIdentifi
JSValueMakeNumber(context, callbackTimeout.value_or(-1))
};

callPropertyFunction(context, scriptObject, "evaluateJavaScriptFunction"_s, std::size(functionArguments), functionArguments, &exception);
{
WebCore::UserGestureIndicator gestureIndicator(WebCore::IsProcessingUserGesture::Yes, frame->coreLocalFrame()->document());
callPropertyFunction(context, scriptObject, "evaluateJavaScriptFunction"_s, std::size(functionArguments), functionArguments, &exception);
}

if (!exception)
return;
Expand Down

0 comments on commit 6444dd0

Please sign in to comment.