Skip to content

Commit

Permalink
[IFC][Geometry] Update final box geometry with logical coords (non-in…
Browse files Browse the repository at this point in the history
…linebox/non-opaque)

https://bugs.webkit.org/show_bug.cgi?id=267181

Reviewed by Antti Koivisto.

Let's keep BoxGeometry logical.

* Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayContentBuilder.cpp:
(WebCore::Layout::InlineDisplayContentBuilder::processNonBidiContent):
(WebCore::Layout::InlineDisplayContentBuilder::adjustVisualGeometryForDisplayBox):
(WebCore::Layout::InlineDisplayContentBuilder::processBidiContent):
(WebCore::Layout::InlineDisplayContentBuilder::applyRubyOverhang):
(WebCore::Layout::convertBoxGeometryForWritingMode): Deleted.

Canonical link: https://commits.webkit.org/272746@main
  • Loading branch information
alanbaradlay committed Jan 7, 2024
1 parent 652de27 commit 64da96e
Show file tree
Hide file tree
Showing 4 changed files with 116 additions and 188 deletions.
2 changes: 1 addition & 1 deletion LayoutTests/fast/ruby/overhang-vertical-expected.txt
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ layer at (0,0) size 800x600
RenderText {#text} at (13,3) size 20x60
text run at (13,3) width 60: "abc"
RenderInline {RUBY} at (0,0) size 20x70 [color=#0000FF]
RenderInline (generated) at (0,0) size 20x71
RenderInline (generated) at (0,0) size 21x70
RenderText {#text} at (13,63) size 20x65
text run at (13,63) width 65: "x x"
RenderBlock {RT} at (3,60) size 10x71 [color=#C0C0C0]
Expand Down
2 changes: 1 addition & 1 deletion LayoutTests/fast/ruby/overhang-vertical-mixed-expected.txt
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ layer at (0,0) size 800x600
RenderText {#text} at (13,3) size 20x60
text run at (13,3) width 60: "abc"
RenderInline {RUBY} at (0,0) size 20x70 [color=#0000FF]
RenderInline (generated) at (0,0) size 20x71
RenderInline (generated) at (0,0) size 21x70
RenderText {#text} at (13,63) size 20x65
text run at (13,63) width 65: "x x"
RenderBlock {RT} at (3,60) size 10x71 [color=#C0C0C0]
Expand Down
Loading

0 comments on commit 64da96e

Please sign in to comment.