Skip to content
Permalink
Browse files
[EWS] Remove extra space from GitHub PR description links
https://bugs.webkit.org/show_bug.cgi?id=241522
<rdar://problem/94842283>

Reviewed by Ryan Haddad.

* Tools/CISupport/ews-build/steps.py:
(UpdatePullRequest): Port changes from 250718@main to EWS.
(UpdatePullRequest.escape_html):
* Tools/CISupport/ews-build/steps_unittest.py:

Canonical link: https://commits.webkit.org/251472@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@295467 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
JonWBedard committed Jun 10, 2022
1 parent d4d7bb7 commit 6616e77e9a718445494fb1cb055f510bf8baed60
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
@@ -5111,7 +5111,7 @@ class UpdatePullRequest(shell.ShellCommand, GitHubMixin, AddToLogMixin):
ESCAPE_TABLE = {
'"': '&quot;',
"'": '&apos;',
'>': ' &gt;',
'>': '&gt;',
'<': '&lt;',
'&': '&amp;',
}
@@ -5126,7 +5126,7 @@ class UpdatePullRequest(shell.ShellCommand, GitHubMixin, AddToLogMixin):
@classmethod
def escape_html(cls, message):
message = ''.join(cls.ESCAPE_TABLE.get(c, c) for c in message)
return re.sub(r'(https?://[^\s<>,:;]+)', r'<a href="\1">\1</a>', message)
return re.sub(r'(https?://[^\s<>,:;]+?)(?=[\s<>,:;]|(&gt))', r'<a href="\1">\1</a>', message)

def __init__(self, **kwargs):
super(UpdatePullRequest, self).__init__(logEnviron=False, timeout=300, **kwargs)
@@ -6317,7 +6317,7 @@ def update_pr(x, pr_number, title, description, base=None, head=None, repository
<pre>
[Merge-Queue] Add http credential helper
<a href="https://bugs.webkit.org/show_bug.cgi?id=238553">https://bugs.webkit.org/show_bug.cgi?id=238553</a>
&lt;rdar://problem/91044821 &gt;
&lt;rdar://problem/91044821&gt;
Reviewed by NOBODY (OOPS!).

0 comments on commit 6616e77

Please sign in to comment.