Clean up type parameter for Event idl

https://bugs.webkit.org/show_bug.cgi?id=217013 Patch by Rob Buis <rbuis@igalia.com> on 2020-09-27 Reviewed by Chris Dumez. LayoutTests/imported/w3c: Update improved test result. * web-platform-tests/html/dom/idlharness.https-expected.txt: Source/WebCore: Clean up type parameter for Event idl files, there is no need to pass "undefined" default value. * dom/CompositionEvent.idl: * dom/HashChangeEvent.idl: * dom/KeyboardEvent.idl: * dom/MouseEvent.idl: * dom/MutationEvent.idl: * dom/TextEvent.idl: * dom/TouchEvent.idl: * dom/UIEvent.idl: * storage/StorageEvent.idl: LayoutTests: Update improved test results. * platform/gtk/imported/w3c/web-platform-tests/html/dom/idlharness.https-expected.txt: * platform/ios-wk2/imported/w3c/web-platform-tests/html/dom/idlharness.https-expected.txt: * platform/mac-wk1/imported/w3c/web-platform-tests/html/dom/idlharness.https-expected.txt: * platform/mac-wk2/imported/w3c/web-platform-tests/html/dom/idlharness.https-expected.txt: * platform/wpe/imported/w3c/web-platform-tests/html/dom/idlharness.https-expected.txt: Canonical link: https://commits.webkit.org/229811@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@267652 268f45cc-cd09-0410-ab3c-d52691b4dbfc
WebKit · Sep 27, 2020 · 6649c3d · 6649c3d
1 parent ee80d85
commit 6649c3d
Show file tree

Hide file tree

Showing 18 changed files with 61 additions and 24 deletions.
diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
@@ -1,3 +1,18 @@
+2020-09-27  Rob Buis  <rbuis@igalia.com>
+
+        Clean up type parameter for Event idl
+        https://bugs.webkit.org/show_bug.cgi?id=217013
+
+        Reviewed by Chris Dumez.
+
+        Update improved test results.
+
+        * platform/gtk/imported/w3c/web-platform-tests/html/dom/idlharness.https-expected.txt:
+        * platform/ios-wk2/imported/w3c/web-platform-tests/html/dom/idlharness.https-expected.txt:
+        * platform/mac-wk1/imported/w3c/web-platform-tests/html/dom/idlharness.https-expected.txt:
+        * platform/mac-wk2/imported/w3c/web-platform-tests/html/dom/idlharness.https-expected.txt:
+        * platform/wpe/imported/w3c/web-platform-tests/html/dom/idlharness.https-expected.txt:
+
 2020-09-26  Wenson Hsieh  <wenson_hsieh@apple.com>
 
         Remove support for setting CMYKA fill and stroke colors in 2D canvas

diff --git a/LayoutTests/imported/w3c/ChangeLog b/LayoutTests/imported/w3c/ChangeLog
@@ -1,3 +1,14 @@
+2020-09-27  Rob Buis  <rbuis@igalia.com>
+
+        Clean up type parameter for Event idl
+        https://bugs.webkit.org/show_bug.cgi?id=217013
+
+        Reviewed by Chris Dumez.
+
+        Update improved test result.
+
+        * web-platform-tests/html/dom/idlharness.https-expected.txt:
+
 2020-09-26  Darin Adler  <darin@apple.com>
 
         Remove trailing spaces from expected.txt files in web-platform-tests/[A-Za-h] minus css, dom, encoding, and html

diff --git a/LayoutTests/imported/w3c/web-platform-tests/html/dom/idlharness.https-expected.txt b/LayoutTests/imported/w3c/web-platform-tests/html/dom/idlharness.https-expected.txt
@@ -4881,7 +4881,7 @@ PASS StorageEvent interface: attribute oldValue
 PASS StorageEvent interface: attribute newValue
 PASS StorageEvent interface: attribute url
 PASS StorageEvent interface: attribute storageArea
-FAIL StorageEvent interface: operation initStorageEvent(DOMString, boolean, boolean, DOMString, DOMString, DOMString, USVString, Storage) assert_equals: property has wrong .length expected 1 but got 0
+PASS StorageEvent interface: operation initStorageEvent(DOMString, boolean, boolean, DOMString, DOMString, DOMString, USVString, Storage)
 PASS HTMLMarqueeElement interface: existence and properties of interface object
 PASS HTMLMarqueeElement interface object length
 PASS HTMLMarqueeElement interface object name

diff --git a/...Tests/platform/gtk/imported/w3c/web-platform-tests/html/dom/idlharness.https-expected.txt b/...Tests/platform/gtk/imported/w3c/web-platform-tests/html/dom/idlharness.https-expected.txt
@@ -5054,7 +5054,7 @@ PASS StorageEvent interface: attribute oldValue
 PASS StorageEvent interface: attribute newValue 
 PASS StorageEvent interface: attribute url 
 PASS StorageEvent interface: attribute storageArea 
-FAIL StorageEvent interface: operation initStorageEvent(DOMString, optional boolean, optional boolean, optional DOMString?, optional DOMString?, optional DOMString?, optional USVString, optional Storage?) assert_equals: property has wrong .length expected 1 but got 0
+PASS StorageEvent interface: operation initStorageEvent(DOMString, optional boolean, optional boolean, optional DOMString?, optional DOMString?, optional DOMString?, optional USVString, optional Storage?)
 PASS HTMLMarqueeElement interface: existence and properties of interface object 
 PASS HTMLMarqueeElement interface object length 
 PASS HTMLMarqueeElement interface object name 

diff --git a/...s/platform/ios-wk2/imported/w3c/web-platform-tests/html/dom/idlharness.https-expected.txt b/...s/platform/ios-wk2/imported/w3c/web-platform-tests/html/dom/idlharness.https-expected.txt
@@ -5044,7 +5044,7 @@ PASS StorageEvent interface: attribute oldValue
 PASS StorageEvent interface: attribute newValue 
 PASS StorageEvent interface: attribute url 
 PASS StorageEvent interface: attribute storageArea 
-FAIL StorageEvent interface: operation initStorageEvent(DOMString, optional boolean, optional boolean, optional DOMString?, optional DOMString?, optional DOMString?, optional USVString, optional Storage?) assert_equals: property has wrong .length expected 1 but got 0
+PASS StorageEvent interface: operation initStorageEvent(DOMString, optional boolean, optional boolean, optional DOMString?, optional DOMString?, optional DOMString?, optional USVString, optional Storage?)
 PASS HTMLMarqueeElement interface: existence and properties of interface object 
 PASS HTMLMarqueeElement interface object length 
 PASS HTMLMarqueeElement interface object name 

diff --git a/...s/platform/mac-wk1/imported/w3c/web-platform-tests/html/dom/idlharness.https-expected.txt b/...s/platform/mac-wk1/imported/w3c/web-platform-tests/html/dom/idlharness.https-expected.txt
@@ -5054,7 +5054,7 @@ PASS StorageEvent interface: attribute oldValue
 PASS StorageEvent interface: attribute newValue 
 PASS StorageEvent interface: attribute url 
 PASS StorageEvent interface: attribute storageArea 
-FAIL StorageEvent interface: operation initStorageEvent(DOMString, optional boolean, optional boolean, optional DOMString?, optional DOMString?, optional DOMString?, optional USVString, optional Storage?) assert_equals: property has wrong .length expected 1 but got 0
+PASS StorageEvent interface: operation initStorageEvent(DOMString, optional boolean, optional boolean, optional DOMString?, optional DOMString?, optional DOMString?, optional USVString, optional Storage?)
 PASS HTMLMarqueeElement interface: existence and properties of interface object 
 PASS HTMLMarqueeElement interface object length 
 PASS HTMLMarqueeElement interface object name 

diff --git a/...s/platform/mac-wk2/imported/w3c/web-platform-tests/html/dom/idlharness.https-expected.txt b/...s/platform/mac-wk2/imported/w3c/web-platform-tests/html/dom/idlharness.https-expected.txt
@@ -5054,7 +5054,7 @@ PASS StorageEvent interface: attribute oldValue
 PASS StorageEvent interface: attribute newValue 
 PASS StorageEvent interface: attribute url 
 PASS StorageEvent interface: attribute storageArea 
-FAIL StorageEvent interface: operation initStorageEvent(DOMString, optional boolean, optional boolean, optional DOMString?, optional DOMString?, optional DOMString?, optional USVString, optional Storage?) assert_equals: property has wrong .length expected 1 but got 0
+PASS StorageEvent interface: operation initStorageEvent(DOMString, optional boolean, optional boolean, optional DOMString?, optional DOMString?, optional DOMString?, optional USVString, optional Storage?)
 PASS HTMLMarqueeElement interface: existence and properties of interface object 
 PASS HTMLMarqueeElement interface object length 
 PASS HTMLMarqueeElement interface object name 

diff --git a/...Tests/platform/wpe/imported/w3c/web-platform-tests/html/dom/idlharness.https-expected.txt b/...Tests/platform/wpe/imported/w3c/web-platform-tests/html/dom/idlharness.https-expected.txt
@@ -5054,7 +5054,7 @@ PASS StorageEvent interface: attribute oldValue
 PASS StorageEvent interface: attribute newValue 
 PASS StorageEvent interface: attribute url 
 PASS StorageEvent interface: attribute storageArea 
-FAIL StorageEvent interface: operation initStorageEvent(DOMString, optional boolean, optional boolean, optional DOMString?, optional DOMString?, optional DOMString?, optional USVString, optional Storage?) assert_equals: property has wrong .length expected 1 but got 0
+PASS StorageEvent interface: operation initStorageEvent(DOMString, optional boolean, optional boolean, optional DOMString?, optional DOMString?, optional DOMString?, optional USVString, optional Storage?)
 PASS HTMLMarqueeElement interface: existence and properties of interface object 
 PASS HTMLMarqueeElement interface object length 
 PASS HTMLMarqueeElement interface object name 

diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
@@ -1,3 +1,23 @@
+2020-09-27  Rob Buis  <rbuis@igalia.com>
+
+        Clean up type parameter for Event idl
+        https://bugs.webkit.org/show_bug.cgi?id=217013
+
+        Reviewed by Chris Dumez.
+
+        Clean up type parameter for Event idl files, there is no need to
+        pass "undefined" default value.
+
+        * dom/CompositionEvent.idl:
+        * dom/HashChangeEvent.idl:
+        * dom/KeyboardEvent.idl:
+        * dom/MouseEvent.idl:
+        * dom/MutationEvent.idl:
+        * dom/TextEvent.idl:
+        * dom/TouchEvent.idl:
+        * dom/UIEvent.idl:
+        * storage/StorageEvent.idl:
+
 2020-09-26  Zalan Bujtas  <zalan@apple.com>
 
         [LFC] Add <wbr> to showLayoutTree

diff --git a/Source/WebCore/dom/CompositionEvent.idl b/Source/WebCore/dom/CompositionEvent.idl
@@ -28,8 +28,7 @@ interface CompositionEvent : UIEvent {
 
     readonly attribute DOMString data;
 
-    // FIXME: Using "undefined" as default parameter value is wrong.
-    undefined initCompositionEvent(optional DOMString typeArg = "undefined",
+    undefined initCompositionEvent(DOMString typeArg,
                               optional boolean canBubbleArg = false,
                               optional boolean cancelableArg = false,
                               optional WindowProxy? viewArg = null,

diff --git a/Source/WebCore/dom/HashChangeEvent.idl b/Source/WebCore/dom/HashChangeEvent.idl
@@ -21,8 +21,7 @@
 interface HashChangeEvent : Event {
     constructor(DOMString type, optional HashChangeEventInit eventInitDict);
 
-    // FIXME: Using "undefined" as default parameter value is wrong.
-    undefined initHashChangeEvent(optional DOMString type = "undefined",
+    undefined initHashChangeEvent(DOMString type,
                              optional boolean canBubble = false,
                              optional boolean cancelable = false,
                              optional USVString oldURL = "undefined",

diff --git a/Source/WebCore/dom/KeyboardEvent.idl b/Source/WebCore/dom/KeyboardEvent.idl
@@ -49,8 +49,7 @@ interface KeyboardEvent : UIEvent {
     readonly attribute unsigned long which;
 
     // FIXME: this does not match the version in the DOM spec.
-    // FIXME: Using "undefined" as default parameter value is wrong.
-    undefined initKeyboardEvent(optional DOMString type = "undefined", optional boolean canBubble = false, optional boolean cancelable = false,
+    undefined initKeyboardEvent(DOMString type, optional boolean canBubble = false, optional boolean cancelable = false,
         optional WindowProxy? view = null, optional DOMString keyIdentifier = "undefined", optional unsigned long location = 0,
         optional boolean ctrlKey = false, optional boolean altKey = false, optional boolean shiftKey = false, optional boolean metaKey = false, optional boolean altGraphKey = false);
 };

diff --git a/Source/WebCore/dom/MouseEvent.idl b/Source/WebCore/dom/MouseEvent.idl
@@ -43,9 +43,8 @@
     [Conditional=POINTER_LOCK] readonly attribute long movementY;
     [Conditional=MOUSE_FORCE_EVENTS, ImplementedAs=force]readonly attribute double webkitForce;
 
-    // FIXME: Using "undefined" as default parameter value is wrong.
     // FIXME: relatedTarget should be of type EventTarget? but we need to use any to support a quirk for iAd Producer (rdar://problem/30640101).
-    [CallWith=GlobalObject&ScriptExecutionContext, ImplementedAs=initMouseEventQuirk] undefined initMouseEvent(optional DOMString type = "undefined",
+    [CallWith=GlobalObject&ScriptExecutionContext, ImplementedAs=initMouseEventQuirk] undefined initMouseEvent(DOMString type,
         optional boolean canBubble = false, optional boolean cancelable = false,
         optional WindowProxy? view = null, optional long detail = 0,
         optional long screenX = 0, optional long screenY = 0, optional long clientX = 0, optional long clientY = 0,

diff --git a/Source/WebCore/dom/MutationEvent.idl b/Source/WebCore/dom/MutationEvent.idl
@@ -29,8 +29,7 @@ interface MutationEvent : Event {
     readonly attribute DOMString attrName;
     readonly attribute unsigned short attrChange;
 
-    // FIXME: Using "undefined" as default parameter value is wrong.
-    undefined initMutationEvent(optional DOMString type = "undefined", optional boolean canBubble = false, optional boolean cancelable = false,
+    undefined initMutationEvent(DOMString type, optional boolean canBubble = false, optional boolean cancelable = false,
         optional Node? relatedNode = null, optional DOMString prevValue = "undefined", optional DOMString newValue = "undefined",
         optional DOMString attrName = "undefined", optional unsigned short attrChange = 0);
 };
diff --git a/Source/WebCore/dom/TextEvent.idl b/Source/WebCore/dom/TextEvent.idl
@@ -28,8 +28,7 @@ interface TextEvent : UIEvent {
 
     readonly attribute DOMString data;
 
-    // FIXME: Using "undefined" as default parameter value is wrong.
-    undefined initTextEvent(optional DOMString typeArg = "undefined",
+    undefined initTextEvent(DOMString typeArg,
                        optional boolean canBubbleArg = false,
                        optional boolean cancelableArg = false,
                        optional WindowProxy? viewArg = null,

diff --git a/Source/WebCore/dom/TouchEvent.idl b/Source/WebCore/dom/TouchEvent.idl
@@ -36,11 +36,10 @@
     readonly attribute boolean altKey;
     readonly attribute boolean metaKey;
 
-    // FIXME: Using "undefined" as default parameter value is wrong.
     undefined initTouchEvent(optional TouchList? touches = null,
                         optional TouchList? targetTouches = null,
                         optional TouchList? changedTouches = null,
-                        optional DOMString type = "undefined",
+                        optional DOMString type,
                         optional WindowProxy? view = null,
                         optional long screenX = 0,
                         optional long screenY = 0,

diff --git a/Source/WebCore/dom/UIEvent.idl b/Source/WebCore/dom/UIEvent.idl
@@ -23,8 +23,7 @@ interface UIEvent : Event {
     readonly attribute WindowProxy view;
     readonly attribute long detail;
 
-    // FIXME: Using "undefined" as default parameter value is wrong.
-    undefined initUIEvent(optional DOMString type = "undefined", optional boolean canBubble = false, optional boolean cancelable = false, optional WindowProxy? view = null, optional long detail = 0);
+    undefined initUIEvent(DOMString type, optional boolean canBubble = false, optional boolean cancelable = false, optional WindowProxy? view = null, optional long detail = 0);
 
     readonly attribute long layerX;
     readonly attribute long layerY;

diff --git a/Source/WebCore/storage/StorageEvent.idl b/Source/WebCore/storage/StorageEvent.idl
@@ -32,8 +32,7 @@ interface StorageEvent : Event {
     readonly attribute USVString url;
     readonly attribute Storage? storageArea;
 
-    // FIXME: Using "undefined" as default parameter value is wrong.
-    undefined initStorageEvent(optional DOMString typeArg = "undefined",
+    undefined initStorageEvent(DOMString typeArg,
                           optional boolean canBubbleArg = false,
                           optional boolean cancelableArg = false,
                           optional DOMString keyArg = "undefined",