Skip to content

Commit

Permalink
--site-isolation reference tests should run both tests in a cross-ori…
Browse files Browse the repository at this point in the history
…gin iframe

https://bugs.webkit.org/show_bug.cgi?id=271283
rdar://125047371

Reviewed by Alex Christensen.

Only the test with site isolation enabled was being run in a cross-origin iframe.

* LayoutTests/platform/mac-site-isolation/TestExpectations:
* Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py:
(_set_up_derived_options):

Canonical link: https://commits.webkit.org/276380@main
  • Loading branch information
charliewolfe committed Mar 20, 2024
1 parent d036679 commit 695ad37
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 6 deletions.
6 changes: 0 additions & 6 deletions LayoutTests/platform/mac-site-isolation/TestExpectations
Original file line number Diff line number Diff line change
Expand Up @@ -218,10 +218,4 @@ http/tests/loading/server-redirect-for-provisional-load-caching.html [ Skip ]
http/tests/loading/simple-subframe.html [ Skip ]
http/tests/loading/slow-parsing-subframe.html [ Skip ]
http/tests/loading/text-content-type-with-binary-extension.html [ Skip ]
http/tests/site-isolation/basic-iframe-render-output.html [ Skip ]
http/tests/site-isolation/basic-iframe.html [ Skip ]
http/tests/site-isolation/double-iframe.html [ Skip ]
http/tests/site-isolation/draw-after-navigation.html [ Skip ]
http/tests/site-isolation/https-load.html [ Skip ]
http/tests/site-isolation/iframe-process-termination.html [ Skip ]
http/tests/site-isolation/notify-done.html [ Skip ]
1 change: 1 addition & 0 deletions Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py
Original file line number Diff line number Diff line change
Expand Up @@ -478,6 +478,7 @@ def _set_up_derived_options(port, options):
options.additional_platform_directory.insert(0, port.host.filesystem.join(host.scm().checkout_root, 'LayoutTests/platform/mac-gpup'))

if port.port_name == "mac" and options.site_isolation:
options.additional_header = 'runInCrossOriginFrame=true'
options.self_compare_with_header = 'SiteIsolationEnabled=true runInCrossOriginFrame=true'
host = Host()
host.initialize_scm()
Expand Down

0 comments on commit 695ad37

Please sign in to comment.