Skip to content

Commit

Permalink
[build.webkit.org] Allow non-buildbot builders
Browse files Browse the repository at this point in the history
https://bugs.webkit.org/show_bug.cgi?id=264645
rdar://118257502

Reviewed by Alexey Proskuryakov.

The bot watcher's dashboard should not assume that all builder queues
are Buildbot builder queues.

* Tools/CISupport/build-webkit-org/public_html/dashboard/Scripts/Main.js:
(documentReady):

Canonical link: https://commits.webkit.org/270667@main
  • Loading branch information
JonWBedard committed Nov 13, 2023
1 parent 0472cd1 commit 6c526fb
Showing 1 changed file with 17 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -222,8 +222,23 @@ function documentReady()
row.appendChild(cell);

cell = document.createElement("td");
var view = new BuildbotBuilderQueueView(platformQueues.builders);
cell.appendChild(view.element);
var queues = {};
var generators = [];

// FIXME: Only required as long as we are mixing XCode Cloud and buildbot builder queues
platformQueues.builders.forEach(function(queue) {
var generator = queue.viewGenerator ? queue.viewGenerator : BuildbotBuilderQueueView;
if (!queues[String(generator)]) {
queues[String(generator)] = [];
generators.push(generator);
}
queues[String(generator)].push(queue);
});

generators.forEach(function(generator) {
var view = new generator(queues[String(generator)]);
cell.appendChild(view.element);
});
row.appendChild(cell);

if ("builderCombinedQueues" in platformQueues) {
Expand Down

0 comments on commit 6c526fb

Please sign in to comment.