jsc.cpp(3614,1): warning: function declared 'noreturn' should not return

https://bugs.webkit.org/show_bug.cgi?id=260330 Reviewed by Ross Kirsling. clang-cl reported the following warnings for Windows port. > WTF\wtf\Assertions.cpp(335,1): warning: function declared 'noreturn' should not return [-Winvalid-noreturn] > JavaScriptCore\jsc.cpp(2602,1): warning: non-void function does not return a value [-Wreturn-type] > JavaScriptCore\jsc.cpp(3614,1): warning: function declared 'noreturn' should not return [-Winvalid-noreturn] Clang-cl should take a code path of GCC for UNUSED_FUNCTION, NO_RETURN and NO_RETURN_WITH_VALUE macros to suppress compiler warnings. * Source/WTF/wtf/Assertions.cpp: * Source/WTF/wtf/Compiler.h: Canonical link: https://commits.webkit.org/266995@main
WebKit · Aug 17, 2023 · 6c660bb · 6c660bb
1 parent 647e462
commit 6c660bb
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/Source/WTF/wtf/Assertions.cpp b/Source/WTF/wtf/Assertions.cpp
@@ -326,7 +326,7 @@ void WTFCrash()
 #else
     *(int *)(uintptr_t)0xbbadbeef = 0;
     // More reliable, but doesn't say BBADBEEF.
-#if COMPILER(GCC_COMPATIBLE)
+#if COMPILER(GCC) || COMPILER(CLANG)
     __builtin_trap();
 #else
     ((void(*)())nullptr)();

diff --git a/Source/WTF/wtf/Compiler.h b/Source/WTF/wtf/Compiler.h
@@ -257,7 +257,7 @@
 
 /* NO_RETURN */
 
-#if !defined(NO_RETURN) && COMPILER(GCC_COMPATIBLE)
+#if !defined(NO_RETURN) && (COMPILER(GCC) || COMPILER(CLANG))
 #define NO_RETURN __attribute((__noreturn__))
 #endif
 
@@ -304,7 +304,7 @@
 
 /* NO_RETURN_WITH_VALUE */
 
-#if !defined(NO_RETURN_WITH_VALUE) && !COMPILER(MSVC)
+#if !defined(NO_RETURN_WITH_VALUE) && (COMPILER(GCC) || COMPILER(CLANG))
 #define NO_RETURN_WITH_VALUE NO_RETURN
 #endif
 
@@ -356,7 +356,7 @@
 
 /* UNUSED_FUNCTION */
 
-#if !defined(UNUSED_FUNCTION) && COMPILER(GCC_COMPATIBLE)
+#if !defined(UNUSED_FUNCTION) && (COMPILER(GCC) || COMPILER(CLANG))
 #define UNUSED_FUNCTION __attribute__((unused))
 #endif