-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
REGRESSION: Two editing/caret/color-span-inside-editable tests are co…
…nstant image failures https://bugs.webkit.org/show_bug.cgi?id=265871 rdar://113875623 Reviewed by Brent Fulgham. There were 2 caret-related changes: A) Caret shape changed between Ventura and Sonoma (from squared to rounded). B) Caret color behavior changed. The caret color should now update in content editable elements if a foreground color is specified. This change was introduced by https://commits.webkit.org/266070@main. Because of (A) we need to rebaseline these tests for the expected values to match the shape of the updated caret. This change is only valid from Sonoma, so we are adding -expected values for Ventura and Monterey, that expect the caret to still be squared. Because of (B) we need to rebaseline these tests for the expected values to match the color of the caret in content editable elements. We also need to update the description of the test themselves to match the new behavior, since before the WebKit change on (B) caret would preserve its color even if set by author. * LayoutTests/editing/caret/color-span-inside-editable-background-expected.html: * LayoutTests/editing/caret/color-span-inside-editable-background.html: * LayoutTests/editing/caret/color-span-inside-editable-expected.html: * LayoutTests/editing/caret/color-span-inside-editable.html: * LayoutTests/platform/gtk/editing/caret/color-span-inside-editable-background-expected.html: Added. * LayoutTests/platform/gtk/editing/caret/color-span-inside-editable-expected.html: Added. * LayoutTests/platform/mac-monterey/editing/caret/color-span-inside-editable-background-expected.html: Added. * LayoutTests/platform/mac-monterey/editing/caret/color-span-inside-editable-expected.html: Added. * LayoutTests/platform/mac-ventura/editing/caret/color-span-inside-editable-background-expected.html: Added. * LayoutTests/platform/mac-ventura/editing/caret/color-span-inside-editable-expected.html: Added. * LayoutTests/platform/mac-wk2/editing/caret/caret-color-expected.png: Removed. * LayoutTests/platform/mac-wk2/editing/caret/color-span-inside-editable-background-expected.html: Removed. * LayoutTests/platform/mac-wk2/editing/caret/color-span-inside-editable-expected.html: Removed. * LayoutTests/platform/mac/TestExpectations: Canonical link: https://commits.webkit.org/271563@main
- Loading branch information
1 parent
85ef0cf
commit 6caa429
Showing
14 changed files
with
30 additions
and
18 deletions.
There are no files selected for viewing
4 changes: 2 additions & 2 deletions
4
LayoutTests/editing/caret/color-span-inside-editable-background-expected.html
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
This test makes sure that carets in content editable divs with a background color specified remain as default even if there is a span inside them with a foreground color specified. | ||
This test makes sure that carets in content editable divs changes color if there is a span inside them with a foreground color specified. | ||
<div style="width: 505px; height: 505px; overflow: hidden;"> | ||
<div style="width: 50px; height: 500px; background-color: red"></div> | ||
<div style="width: 100px; height: 500px; background-color: red; border-radius: 50px;"></div> | ||
</div> |
2 changes: 1 addition & 1 deletion
2
LayoutTests/editing/caret/color-span-inside-editable-background.html
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 changes: 2 additions & 2 deletions
4
LayoutTests/editing/caret/color-span-inside-editable-expected.html
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
This test makes sure that carets in content editable divs remain as default if there is a span inside them with a foreground color specified. | ||
This test makes sure that carets in content editable divs changes color if there is a span inside them with a foreground color specified. | ||
<div style="width: 505px; height: 505px; overflow: hidden;"> | ||
<div style="width: 50px; height: 500px; background-color: red"></div> | ||
<div style="width: 100px; height: 500px; background-color: red; border-radius: 50px;"></div> | ||
</div> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 changes: 4 additions & 0 deletions
4
LayoutTests/platform/gtk/editing/caret/color-span-inside-editable-background-expected.html
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
This test makes sure that carets in content editable divs changes color if there is a span inside them with a foreground color specified. | ||
<div style="width: 505px; height: 505px; overflow: hidden;"> | ||
<div style="width: 50px; height: 500px; background-color: red"></div> | ||
</div> |
4 changes: 4 additions & 0 deletions
4
LayoutTests/platform/gtk/editing/caret/color-span-inside-editable-expected.html
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
This test makes sure that carets in content editable divs changes color if there is a span inside them with a foreground color specified. | ||
<div style="width: 505px; height: 505px; overflow: hidden;"> | ||
<div style="width: 50px; height: 500px; background-color: red"></div> | ||
</div> |
4 changes: 4 additions & 0 deletions
4
...s/platform/mac-monterey/editing/caret/color-span-inside-editable-background-expected.html
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
This test makes sure that carets in content editable divs changes color if there is a span inside them with a foreground color specified. | ||
<div style="width: 505px; height: 505px; overflow: hidden;"> | ||
<div style="width: 50px; height: 500px; background-color: red"></div> | ||
</div> |
4 changes: 4 additions & 0 deletions
4
LayoutTests/platform/mac-monterey/editing/caret/color-span-inside-editable-expected.html
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
This test makes sure that carets in content editable divs changes color if there is a span inside them with a foreground color specified. | ||
<div style="width: 505px; height: 505px; overflow: hidden;"> | ||
<div style="width: 50px; height: 500px; background-color: red"></div> | ||
</div> |
4 changes: 4 additions & 0 deletions
4
...ts/platform/mac-ventura/editing/caret/color-span-inside-editable-background-expected.html
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
This test makes sure that carets in content editable divs changes color if there is a span inside them with a foreground color specified. | ||
<div style="width: 505px; height: 505px; overflow: hidden;"> | ||
<div style="width: 50px; height: 500px; background-color: red"></div> | ||
</div> |
4 changes: 4 additions & 0 deletions
4
LayoutTests/platform/mac-ventura/editing/caret/color-span-inside-editable-expected.html
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
This test makes sure that carets in content editable divs changes color if there is a span inside them with a foreground color specified. | ||
<div style="width: 505px; height: 505px; overflow: hidden;"> | ||
<div style="width: 50px; height: 500px; background-color: red"></div> | ||
</div> |
Binary file removed
BIN
-24.2 KB
LayoutTests/platform/mac-wk2/editing/caret/caret-color-expected.png
Binary file not shown.
4 changes: 0 additions & 4 deletions
4
...tTests/platform/mac-wk2/editing/caret/color-span-inside-editable-background-expected.html
This file was deleted.
Oops, something went wrong.
4 changes: 0 additions & 4 deletions
4
LayoutTests/platform/mac-wk2/editing/caret/color-span-inside-editable-expected.html
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters