Skip to content
Permalink
Browse files
Only send a synthetic mouse out event if synthetic mouse move events …
…were sent.

https://bugs.webkit.org/show_bug.cgi?id=197295
rdar://problem/49040233

Reviewed by Zalan Bujtas.

* WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::completeSyntheticClick):


Canonical link: https://commits.webkit.org/211507@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244667 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
xeenon committed Apr 25, 2019
1 parent 410abb3 commit 6daeb460a82f179d7cb67605ac89465ab57c23d9
Showing 2 changed files with 14 additions and 1 deletion.
@@ -1,3 +1,14 @@
2019-04-25 Timothy Hatcher <timothy@apple.com>

Only send a synthetic mouse out event if synthetic mouse move events were sent.
https://bugs.webkit.org/show_bug.cgi?id=197295
rdar://problem/49040233

Reviewed by Zalan Bujtas.

* WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::completeSyntheticClick):

2019-04-25 Timothy Hatcher <timothy@apple.com>

Disable date and time inputs on iOSMac.
@@ -689,8 +689,10 @@ static bool nodeAlwaysTriggersClick(const Node& targetNode)
if (newFocusedElement && newFocusedElement == oldFocusedElement)
elementDidRefocus(*newFocusedElement);

if (!tapWasHandled && nodeRespondingToClick.document().frame())
// Only send a synthetic mouse out event if synthetic mouse move events were sent; this is true when ContentChangeObserver is enabled.
if (nodeRespondingToClick.document().settings().contentChangeObserverEnabled() && !tapWasHandled && nodeRespondingToClick.document().frame())
nodeRespondingToClick.document().frame()->eventHandler().dispatchSyntheticMouseOut(PlatformMouseEvent(roundedAdjustedPoint, roundedAdjustedPoint, LeftButton, PlatformEvent::NoType, 0, shiftKey, ctrlKey, altKey, metaKey, WallTime::now(), 0, WebCore::NoTap));

if (m_isClosed)
return;

0 comments on commit 6daeb46

Please sign in to comment.