-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[JSC] sourceURLStripped should be cached
https://bugs.webkit.org/show_bug.cgi?id=259969 rdar://113616170 Reviewed by Keith Miller. 262420@main introduced sourceURLStripped for error stack URLs. However this is really costly operation, as a result, it makes error stack string generation slower. JetStream2/chai-wtb is frequently creating this error stack string, so this is affected by this change by up to 5%. This patch fixes the above performance issue by caching sourceURLStripped in SourceProvider. * Source/JavaScriptCore/parser/SourceProvider.cpp: (JSC::SourceProvider::sourceURLStripped): * Source/JavaScriptCore/parser/SourceProvider.h: * Source/JavaScriptCore/runtime/ScriptExecutable.h: (JSC::ScriptExecutable::sourceURLStripped const): * Source/JavaScriptCore/runtime/StackFrame.cpp: (JSC::processSourceURL): (JSC::StackFrame::sourceURL const): (JSC::StackFrame::sourceURLStripped const): Canonical link: https://commits.webkit.org/266728@main
- Loading branch information
1 parent
9790360
commit 6fb2754
Showing
4 changed files
with
33 additions
and
11 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters