Skip to content

Commit

Permalink
[Skia] Test fast/canvas/canvas-composite-stroke-alpha.html is failing
Browse files Browse the repository at this point in the history
https://bugs.webkit.org/show_bug.cgi?id=273471

Reviewed by Carlos Garcia Campos.

This change fixes lack of blending on stroking.

* LayoutTests/platform/glib/TestExpectations:
* Source/WebCore/platform/graphics/skia/GraphicsContextSkia.cpp:
(WebCore::GraphicsContextSkia::createStrokePaint const):

Canonical link: https://commits.webkit.org/278743@main
  • Loading branch information
Scony authored and carlosgcampos committed May 14, 2024
1 parent 5fb5104 commit 7051b8f
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 2 deletions.
2 changes: 0 additions & 2 deletions LayoutTests/platform/glib/TestExpectations
Original file line number Diff line number Diff line change
Expand Up @@ -1656,8 +1656,6 @@ webkit.org/b/273396 mathml/presentation/mo-stacked-glyphs.html [ ImageOnlyFailur
webkit.org/b/273396 svg/animations/animateMotion-accumulate-1a.svg [ ImageOnlyFailure ]
webkit.org/b/273396 svg/animations/animateMotion-accumulate-1b.svg [ ImageOnlyFailure ]

webkit.org/b/273471 fast/canvas/canvas-composite-stroke-alpha.html [ Failure ]

webkit.org/b/273472 fast/css3-text/font-synthesis.html [ ImageOnlyFailure ]

webkit.org/b/273474 fast/text/emoji-variation-selector.html [ ImageOnlyFailure ]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -478,6 +478,7 @@ SkPaint GraphicsContextSkia::createStrokePaint() const
SkPaint paint;
paint.setAntiAlias(shouldAntialias());
paint.setStyle(SkPaint::kStroke_Style);
paint.setBlendMode(toSkiaBlendMode(compositeMode().operation, blendMode()));
paint.setStrokeCap(m_skiaState.m_stroke.cap);
paint.setStrokeJoin(m_skiaState.m_stroke.join);
paint.setStrokeMiter(m_skiaState.m_stroke.miter);
Expand Down

0 comments on commit 7051b8f

Please sign in to comment.