Skip to content

Commit

Permalink
Unreviewed, reverting 271110@main.
Browse files Browse the repository at this point in the history 
https://bugs.webkit.org/show_bug.cgi?id=265358

Speedometer3 1% regression

Reverted changeset:

"[scroll-animations] implement parsing support for scroll-timeline and its longhand properties"
https://bugs.webkit.org/show_bug.cgi?id=265302
https://commits.webkit.org/271110@main

Canonical link: https://commits.webkit.org/271127@main
  • Loading branch information
@webkit-commit-queue @Constellation
webkit-commit-queue authored and Constellation committed Nov 26, 2023
1 parent 8258cee commit 70f088f
Show file tree
Hide file tree
Showing 32 changed files with 96 additions and 387 deletions.
2 changes: 0 additions & 2 deletions ...utTests/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt
View file
Original file line number Diff line number Diff line change
Expand Up @@ -288,8 +288,6 @@ PASS scroll-padding-top
PASS scroll-snap-align
PASS scroll-snap-stop
PASS scroll-snap-type
PASS scroll-timeline-axis
PASS scroll-timeline-name
PASS scrollbar-color
PASS scrollbar-gutter
PASS scrollbar-width
Expand Down
2 changes: 0 additions & 2 deletions ...tTests/imported/w3c/web-platform-tests/css/css-cascade/all-prop-revert-layer-expected.txt
View file
Original file line number Diff line number Diff line change
Expand Up @@ -278,8 +278,6 @@ PASS scroll-padding-top
PASS scroll-snap-align
PASS scroll-snap-stop
PASS scroll-snap-type
PASS scroll-timeline-axis
PASS scroll-timeline-name
PASS scrollbar-color
PASS scrollbar-gutter
PASS scrollbar-width
Expand Down
28 changes: 14 additions & 14 deletions ...d/w3c/web-platform-tests/scroll-animations/css/scroll-timeline-axis-computed-expected.txt
View file
Original file line number Diff line number Diff line change
@@ -1,16 +1,16 @@

PASS Property scroll-timeline-axis value 'initial'
PASS Property scroll-timeline-axis value 'inherit'
PASS Property scroll-timeline-axis value 'unset'
PASS Property scroll-timeline-axis value 'revert'
PASS Property scroll-timeline-axis value 'block'
PASS Property scroll-timeline-axis value 'inline'
PASS Property scroll-timeline-axis value 'y'
PASS Property scroll-timeline-axis value 'x'
PASS Property scroll-timeline-axis value 'block, inline'
PASS Property scroll-timeline-axis value 'inline, block'
PASS Property scroll-timeline-axis value 'block, y, x, inline'
PASS Property scroll-timeline-axis value 'inline, inline, inline, inline'
PASS The scroll-timeline-axis property shows up in CSSStyleDeclaration enumeration
PASS The scroll-timeline-axis property shows up in CSSStyleDeclaration.cssText
FAIL Property scroll-timeline-axis value 'initial' assert_true: scroll-timeline-axis doesn't seem to be supported in the computed style expected true got false
FAIL Property scroll-timeline-axis value 'inherit' assert_true: scroll-timeline-axis doesn't seem to be supported in the computed style expected true got false
FAIL Property scroll-timeline-axis value 'unset' assert_true: scroll-timeline-axis doesn't seem to be supported in the computed style expected true got false
FAIL Property scroll-timeline-axis value 'revert' assert_true: scroll-timeline-axis doesn't seem to be supported in the computed style expected true got false
FAIL Property scroll-timeline-axis value 'block' assert_true: scroll-timeline-axis doesn't seem to be supported in the computed style expected true got false
FAIL Property scroll-timeline-axis value 'inline' assert_true: scroll-timeline-axis doesn't seem to be supported in the computed style expected true got false
FAIL Property scroll-timeline-axis value 'y' assert_true: scroll-timeline-axis doesn't seem to be supported in the computed style expected true got false
FAIL Property scroll-timeline-axis value 'x' assert_true: scroll-timeline-axis doesn't seem to be supported in the computed style expected true got false
FAIL Property scroll-timeline-axis value 'block, inline' assert_true: scroll-timeline-axis doesn't seem to be supported in the computed style expected true got false
FAIL Property scroll-timeline-axis value 'inline, block' assert_true: scroll-timeline-axis doesn't seem to be supported in the computed style expected true got false
FAIL Property scroll-timeline-axis value 'block, y, x, inline' assert_true: scroll-timeline-axis doesn't seem to be supported in the computed style expected true got false
FAIL Property scroll-timeline-axis value 'inline, inline, inline, inline' assert_true: scroll-timeline-axis doesn't seem to be supported in the computed style expected true got false
FAIL The scroll-timeline-axis property shows up in CSSStyleDeclaration enumeration assert_not_equals: got disallowed value -1
FAIL The scroll-timeline-axis property shows up in CSSStyleDeclaration.cssText assert_not_equals: got disallowed value -1

24 changes: 12 additions & 12 deletions ...ed/w3c/web-platform-tests/scroll-animations/css/scroll-timeline-axis-parsing-expected.txt
View file
Original file line number Diff line number Diff line change
@@ -1,16 +1,16 @@

PASS e.style['scroll-timeline-axis'] = "initial" should set the property value
PASS e.style['scroll-timeline-axis'] = "inherit" should set the property value
PASS e.style['scroll-timeline-axis'] = "unset" should set the property value
PASS e.style['scroll-timeline-axis'] = "revert" should set the property value
PASS e.style['scroll-timeline-axis'] = "block" should set the property value
PASS e.style['scroll-timeline-axis'] = "inline" should set the property value
PASS e.style['scroll-timeline-axis'] = "y" should set the property value
PASS e.style['scroll-timeline-axis'] = "x" should set the property value
PASS e.style['scroll-timeline-axis'] = "block, inline" should set the property value
PASS e.style['scroll-timeline-axis'] = "inline, block" should set the property value
PASS e.style['scroll-timeline-axis'] = "block, y, x, inline" should set the property value
PASS e.style['scroll-timeline-axis'] = "inline, inline, inline, inline" should set the property value
FAIL e.style['scroll-timeline-axis'] = "initial" should set the property value assert_not_equals: property should be set got disallowed value ""
FAIL e.style['scroll-timeline-axis'] = "inherit" should set the property value assert_not_equals: property should be set got disallowed value ""
FAIL e.style['scroll-timeline-axis'] = "unset" should set the property value assert_not_equals: property should be set got disallowed value ""
FAIL e.style['scroll-timeline-axis'] = "revert" should set the property value assert_not_equals: property should be set got disallowed value ""
FAIL e.style['scroll-timeline-axis'] = "block" should set the property value assert_not_equals: property should be set got disallowed value ""
FAIL e.style['scroll-timeline-axis'] = "inline" should set the property value assert_not_equals: property should be set got disallowed value ""
FAIL e.style['scroll-timeline-axis'] = "y" should set the property value assert_not_equals: property should be set got disallowed value ""
FAIL e.style['scroll-timeline-axis'] = "x" should set the property value assert_not_equals: property should be set got disallowed value ""
FAIL e.style['scroll-timeline-axis'] = "block, inline" should set the property value assert_not_equals: property should be set got disallowed value ""
FAIL e.style['scroll-timeline-axis'] = "inline, block" should set the property value assert_not_equals: property should be set got disallowed value ""
FAIL e.style['scroll-timeline-axis'] = "block, y, x, inline" should set the property value assert_not_equals: property should be set got disallowed value ""
FAIL e.style['scroll-timeline-axis'] = "inline, inline, inline, inline" should set the property value assert_not_equals: property should be set got disallowed value ""
PASS e.style['scroll-timeline-axis'] = "abc" should not set the property value
PASS e.style['scroll-timeline-axis'] = "10px" should not set the property value
PASS e.style['scroll-timeline-axis'] = "auto" should not set the property value
Expand Down
26 changes: 13 additions & 13 deletions ...d/w3c/web-platform-tests/scroll-animations/css/scroll-timeline-name-computed-expected.txt
View file
Original file line number Diff line number Diff line change
@@ -1,15 +1,15 @@

PASS Property scroll-timeline-name value 'initial'
PASS Property scroll-timeline-name value 'inherit'
PASS Property scroll-timeline-name value 'unset'
PASS Property scroll-timeline-name value 'revert'
PASS Property scroll-timeline-name value 'none'
PASS Property scroll-timeline-name value '--foo'
PASS Property scroll-timeline-name value '--foo, --bar'
PASS Property scroll-timeline-name value '--bar, --foo'
PASS Property scroll-timeline-name value '--a, --b, --c, --D, --e'
PASS Property scroll-timeline-name value 'none, none'
PASS Property scroll-timeline-name value '--a, --b, --c, none, --d, --e'
PASS The scroll-timeline-name property shows up in CSSStyleDeclaration enumeration
PASS The scroll-timeline-name property shows up in CSSStyleDeclaration.cssText
FAIL Property scroll-timeline-name value 'initial' assert_true: scroll-timeline-name doesn't seem to be supported in the computed style expected true got false
FAIL Property scroll-timeline-name value 'inherit' assert_true: scroll-timeline-name doesn't seem to be supported in the computed style expected true got false
FAIL Property scroll-timeline-name value 'unset' assert_true: scroll-timeline-name doesn't seem to be supported in the computed style expected true got false
FAIL Property scroll-timeline-name value 'revert' assert_true: scroll-timeline-name doesn't seem to be supported in the computed style expected true got false
FAIL Property scroll-timeline-name value 'none' assert_true: scroll-timeline-name doesn't seem to be supported in the computed style expected true got false
FAIL Property scroll-timeline-name value '--foo' assert_true: scroll-timeline-name doesn't seem to be supported in the computed style expected true got false
FAIL Property scroll-timeline-name value '--foo, --bar' assert_true: scroll-timeline-name doesn't seem to be supported in the computed style expected true got false
FAIL Property scroll-timeline-name value '--bar, --foo' assert_true: scroll-timeline-name doesn't seem to be supported in the computed style expected true got false
FAIL Property scroll-timeline-name value '--a, --b, --c, --D, --e' assert_true: scroll-timeline-name doesn't seem to be supported in the computed style expected true got false
FAIL Property scroll-timeline-name value 'none, none' assert_true: scroll-timeline-name doesn't seem to be supported in the computed style expected true got false
FAIL Property scroll-timeline-name value '--a, --b, --c, none, --d, --e' assert_true: scroll-timeline-name doesn't seem to be supported in the computed style expected true got false
FAIL The scroll-timeline-name property shows up in CSSStyleDeclaration enumeration assert_not_equals: got disallowed value -1
FAIL The scroll-timeline-name property shows up in CSSStyleDeclaration.cssText assert_not_equals: got disallowed value -1

24 changes: 12 additions & 12 deletions ...ed/w3c/web-platform-tests/scroll-animations/css/scroll-timeline-name-parsing-expected.txt
View file
Original file line number Diff line number Diff line change
@@ -1,16 +1,16 @@

PASS e.style['scroll-timeline-name'] = "initial" should set the property value
PASS e.style['scroll-timeline-name'] = "inherit" should set the property value
PASS e.style['scroll-timeline-name'] = "unset" should set the property value
PASS e.style['scroll-timeline-name'] = "revert" should set the property value
PASS e.style['scroll-timeline-name'] = "none" should set the property value
PASS e.style['scroll-timeline-name'] = "--abc" should set the property value
PASS e.style['scroll-timeline-name'] = " --abc" should set the property value
PASS e.style['scroll-timeline-name'] = "--aBc" should set the property value
PASS e.style['scroll-timeline-name'] = "--foo, --bar" should set the property value
PASS e.style['scroll-timeline-name'] = "--bar, --foo" should set the property value
PASS e.style['scroll-timeline-name'] = "none, none" should set the property value
PASS e.style['scroll-timeline-name'] = "--a, none, --b" should set the property value
FAIL e.style['scroll-timeline-name'] = "initial" should set the property value assert_not_equals: property should be set got disallowed value ""
FAIL e.style['scroll-timeline-name'] = "inherit" should set the property value assert_not_equals: property should be set got disallowed value ""
FAIL e.style['scroll-timeline-name'] = "unset" should set the property value assert_not_equals: property should be set got disallowed value ""
FAIL e.style['scroll-timeline-name'] = "revert" should set the property value assert_not_equals: property should be set got disallowed value ""
FAIL e.style['scroll-timeline-name'] = "none" should set the property value assert_not_equals: property should be set got disallowed value ""
FAIL e.style['scroll-timeline-name'] = "--abc" should set the property value assert_not_equals: property should be set got disallowed value ""
FAIL e.style['scroll-timeline-name'] = " --abc" should set the property value assert_not_equals: property should be set got disallowed value ""
FAIL e.style['scroll-timeline-name'] = "--aBc" should set the property value assert_not_equals: property should be set got disallowed value ""
FAIL e.style['scroll-timeline-name'] = "--foo, --bar" should set the property value assert_not_equals: property should be set got disallowed value ""
FAIL e.style['scroll-timeline-name'] = "--bar, --foo" should set the property value assert_not_equals: property should be set got disallowed value ""
FAIL e.style['scroll-timeline-name'] = "none, none" should set the property value assert_not_equals: property should be set got disallowed value ""
FAIL e.style['scroll-timeline-name'] = "--a, none, --b" should set the property value assert_not_equals: property should be set got disallowed value ""
PASS e.style['scroll-timeline-name'] = "auto" should not set the property value
PASS e.style['scroll-timeline-name'] = "abc" should not set the property value
PASS e.style['scroll-timeline-name'] = "default" should not set the property value
Expand Down
Loading

0 comments on commit 70f088f

Please sign in to comment.