Merge r222204 - WebDriver: wrong key name for capabilities in new ses…

…sion response https://bugs.webkit.org/show_bug.cgi?id=177074 Reviewed by Brian Burg. We are using "value", it should be "capabilities". https://w3c.github.io/webdriver/webdriver-spec.html#new-session * WebDriverService.cpp: (WebDriver::WebDriverService::newSession):
WebKit · Oct 16, 2017 · 7104353 · 7104353
1 parent 09aa896
commit 7104353
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 1 deletion.
diff --git a/Source/WebDriver/ChangeLog b/Source/WebDriver/ChangeLog
@@ -1,3 +1,16 @@
+2017-09-18  Carlos Garcia Campos  <cgarcia@igalia.com>
+
+        WebDriver: wrong key name for capabilities in new session response
+        https://bugs.webkit.org/show_bug.cgi?id=177074
+
+        Reviewed by Brian Burg.
+
+        We are using "value", it should be "capabilities".
+        https://w3c.github.io/webdriver/webdriver-spec.html#new-session
+
+        * WebDriverService.cpp:
+        (WebDriver::WebDriverService::newSession):
+
 2017-09-18  Carlos Garcia Campos  <cgarcia@igalia.com>
 
         WebDriver: HTTP responses should include Cache-Control header with no-cache value

diff --git a/Source/WebDriver/WebDriverService.cpp b/Source/WebDriver/WebDriverService.cpp
@@ -625,7 +625,7 @@ void WebDriverService::newSession(RefPtr<InspectorObject>&& parameters, Function
                     break;
                 }
             }
-            resultObject->setObject(ASCIILiteral("value"), WTFMove(capabilitiesObject));
+            resultObject->setObject(ASCIILiteral("capabilities"), WTFMove(capabilitiesObject));
             completionHandler(CommandResult::success(WTFMove(resultObject)));
         });
     });