Skip to content

Commit

Permalink
[results.webkit.org] Separate failures between runs sharing a configu…
Browse files Browse the repository at this point in the history
…ration

https://bugs.webkit.org/show_bug.cgi?id=271807
rdar://125515440

Reviewed by Ryan Haddad.

* Tools/Scripts/libraries/resultsdbpy/resultsdbpy/view/static/js/investigate.js:
(_InvestigateDrawer.prototype.dispatch): Only assign a Failure object to a run if the UUID and
build time of the Failure match the current run.

Canonical link: https://commits.webkit.org/276786@main
  • Loading branch information
JonWBedard committed Mar 28, 2024
1 parent 53f3bab commit 72cd3b4
Showing 1 changed file with 5 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -114,8 +114,6 @@ function prioritizedFailures(failures, max = 0, willFilterExpected = false)
failuresToDisplay[max - 1] = null;
}



return `<div>${failuresToDisplay.map(failure => {
if (failure === null) {
const params = failures.toParams();
Expand Down Expand Up @@ -367,7 +365,11 @@ class _InvestigateDrawer {
this.data.forEach(datum => {
datum.failures = new Failures(this.suite, datum.configuration);
failures.forEach(failure => {
if (datum.configuration.compare(failure.configuration) === 0)
if (
datum.configuration.compare(failure.configuration) === 0 &&
failure.uuid_range[0] <= datum.uuid && datum.uuid <= failure.uuid_range[1] &&
failure.start_time_range[0] <= datum.start_time && datum.start_time <= failure.start_time_range[1]
)
datum.failures = Failures.combine(datum.failures, failure);
});
});
Expand Down

0 comments on commit 72cd3b4

Please sign in to comment.