-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[IFC][Cleanup] Variable names should reflect whether they are logical…
… or visual https://bugs.webkit.org/show_bug.cgi?id=267018 Reviewed by Antti Koivisto. We normally deal with logical coords in layout and mix them with visual coords only at display content construction. This patch makes it clear whether a local variable holds logical or visual coords. * Source/WebCore/layout/formattingContexts/inline/InlineFormattingContext.cpp: Let's just pass in LineBox at construction time so that we don't have to pass it around in InlineDisplayContentBuilder. (WebCore::Layout::InlineFormattingContext::createDisplayContentForInlineContent): * Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayContentBuilder.cpp: (WebCore::Layout::InlineDisplayContentBuilder::InlineDisplayContentBuilder): (WebCore::Layout::InlineDisplayContentBuilder::build): (WebCore::Layout::InlineDisplayContentBuilder::appendTextDisplayBox): (WebCore::Layout::InlineDisplayContentBuilder::appendSoftLineBreakDisplayBox): (WebCore::Layout::InlineDisplayContentBuilder::appendHardLineBreakDisplayBox): (WebCore::Layout::InlineDisplayContentBuilder::appendAtomicInlineLevelDisplayBox): (WebCore::Layout::InlineDisplayContentBuilder::appendRootInlineBoxDisplayBox): (WebCore::Layout::InlineDisplayContentBuilder::appendInlineBoxDisplayBox): (WebCore::Layout::InlineDisplayContentBuilder::appendInlineDisplayBoxAtBidiBoundary): (WebCore::Layout::InlineDisplayContentBuilder::insertRubyAnnotationBox): (WebCore::Layout::InlineDisplayContentBuilder::processNonBidiContent): (WebCore::Layout::InlineDisplayContentBuilder::adjustVisualGeometryForDisplayBox): (WebCore::Layout::InlineDisplayContentBuilder::processBidiContent): (WebCore::Layout::InlineDisplayContentBuilder::setGeometryForBlockLevelOutOfFlowBoxes): * Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayContentBuilder.h: (WebCore::Layout::InlineDisplayContentBuilder::setGeometryForBlockLevelOutOfFlowBoxes): (WebCore::Layout::InlineDisplayContentBuilder::lineBox const): (WebCore::Layout::InlineDisplayContentBuilder::lineIndex const): (WebCore::Layout::InlineDisplayContentBuilder::rootStyle const): * Source/WebCore/layout/formattingContexts/inline/ruby/RubyFormattingContext.cpp: (WebCore::Layout::RubyFormattingContext::baseEndAdditionalLogicalWidth): (WebCore::Layout::RubyFormattingContext::placeAnnotationBox): (WebCore::Layout::RubyFormattingContext::sizeAnnotationBox): (WebCore::Layout::RubyFormattingContext::baseEndAdditionalVisualWidth): Deleted. * Source/WebCore/layout/formattingContexts/inline/ruby/RubyFormattingContext.h: Canonical link: https://commits.webkit.org/272609@main
- Loading branch information
1 parent
aec9d2a
commit 74ebfc4
Showing
5 changed files
with
70 additions
and
66 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.