Skip to content

Commit

Permalink
Update comments for beginParsingChildren and finishParsingChildren
Browse files Browse the repository at this point in the history
https://bugs.webkit.org/show_bug.cgi?id=268319

Reviewed by Anne van Kesteren.

Updated the comment to explain why relying on these functions should be avoided.

* Source/WebCore/dom/Element.h:

Canonical link: https://commits.webkit.org/273732@main
  • Loading branch information
rniwa committed Jan 30, 2024
1 parent 1a21a03 commit 757c894
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion Source/WebCore/dom/Element.h
Original file line number Diff line number Diff line change
Expand Up @@ -513,7 +513,8 @@ class Element : public ContainerNode {
virtual void didStopBeingFullscreenElement() { }

bool isFinishedParsingChildren() const { return isParsingChildrenFinished(); }
// Overriding these functions to make parsing a special case should be avoided if possible.
// Overriding these functions to make parsing a special case should be avoided if possible
// as that could lead to elements responding differently to the parser vs. other kinds of DOM mutations.
void beginParsingChildren() { clearIsParsingChildrenFinished(); }
virtual void finishParsingChildren();

Expand Down

0 comments on commit 757c894

Please sign in to comment.